arm64 support #35
Merged
arm64 support #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stripedpajamas
requested changes
Oct 10, 2018
install_deps.sh
Outdated
| @@ -5,6 +5,10 @@ if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then | |||
| brew install yarn --without-node | |||
| brew install jq zip | |||
| else | |||
| # Use the default C / C++ compilers, | |||
| # because some makefiles default to CC:=gcc: | |||
| export CC=/usr/bin/cc | |||
There was a problem hiding this comment.
Can you set these two compiler variables in a conditional block for "$BUILDARCH" == "arm64" so we are sure it doesn't mess up the other builds? If it means copying some of the apt-get commands into that block that's fine. The other builds are just very particular so I don't want to risk muddying the waters.
build.sh
Outdated
| elif [[ "$BUILDARCH" == "arm64" ]]; then | ||
| npm run gulp vscode-linux-arm64-min | ||
| npm run gulp vscode-linux-arm64-build-deb | ||
| npm run gulp vscode-linux-arm64-build-rpm |
There was a problem hiding this comment.
As per my other comment, comment out L36 until MS gets arm64 rpm support.
|
Sure! Will be working on it now. |
|
Just commited the changes. |
Whoops, commited here instead of arm64-myrepo branch.
stripedpajamas
approved these changes
Oct 10, 2018
|
Yes, we do. AArch64 Chromebooks can't run AArch64 apps. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have modified the files to build and deploy arm64 packages using Travis CI, which fixes issue #6.
However, the RPM builds for arm64 don't work for some reason, I think it's an error on the vscode rpm gulpfile...
The link for the file in the Vscode repository is here.
Other than that, the build went pretty smoothly, deploying both the
.tar.gzand the.debfiles.