-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In file context menu change 'Open with VSCodium' to 'Open with Codium' #369
Comments
Thanks for the link. I see that #193 is closed. |
#193 is not closed and will cover this change. PRs are welcome if anyone wants to just get the context menu change into the next release. |
This issue is NOT covered by #193 This issue is about renaming the context menu entry 'Open with VSCodium' to 'Open with Codium'.
Issue has not been fixed. Please reopen.
Just proves that #369 has not (yet) been fixed. |
@lnlp #193 is about making VSCodium's naming conventions consistent with VSCode's naming conventions. This includes the context menu entry. You can see the same in the draft PR associated with #193. Specifically, the context menu entry sources its wording/name from the As I said, if anyone wants only this change before we figure out how to align all our naming conventions with VSCode's, PRs are welcome. We don't need separate issues for each place in the application where our naming conventions differ from upstream's. |
That is incorrect. #193 is not about making naming conventions consistent with VSCode. It is actually the opposite: remove "VS" from the VSCodium product name. Inconsistency:
The inconsistency is that VSCode does not use the "VS" prefix in that menu but VSCodium does (and "Codium" just looks better). There are two possible reasons for correcting the 'Open with' menu entry:
Reason 1. is VALID. Fixing the menu entry inconsistency should not be made dependent on a possible future change of product name that may never happen. That is just incorrect. There currently already exists a valid reason to correct the menu entry and that is reason 1. This issue should therefore be reopend (until it actually gets fixed). |
I use VSCodium on Windows.
In the file context menu it shows 'Open with VSCodium', where VSCode only shows 'Open with Code'.
It would be nice to see 'Open with Codium' for VSCodium instead.
That is consistent with VSCode behavior, is consistent with how the executables are named and is consistent with how VSCodium is started from a command line.
The text was updated successfully, but these errors were encountered: