Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In file context menu change 'Open with VSCodium' to 'Open with Codium' #369

Closed
lnlp opened this issue Mar 25, 2020 · 6 comments
Closed

In file context menu change 'Open with VSCodium' to 'Open with Codium' #369

lnlp opened this issue Mar 25, 2020 · 6 comments
Labels
bug Something isn't working

Comments

@lnlp
Copy link

lnlp commented Mar 25, 2020

I use VSCodium on Windows.
In the file context menu it shows 'Open with VSCodium', where VSCode only shows 'Open with Code'.

It would be nice to see 'Open with Codium' for VSCodium instead.
That is consistent with VSCode behavior, is consistent with how the executables are named and is consistent with how VSCodium is started from a command line.

@lnlp lnlp added the bug Something isn't working label Mar 25, 2020
@bulderi
Copy link

bulderi commented Mar 27, 2020

See 193

@lnlp
Copy link
Author

lnlp commented Mar 28, 2020

Thanks for the link. I see that #193 is closed.
My suggestion has less impact, is consistent with VSCode and should be easy to implement.

@stripedpajamas
Copy link
Member

#193 is not closed and will cover this change. PRs are welcome if anyone wants to just get the context menu change into the next release.

@lnlp
Copy link
Author

lnlp commented Jun 10, 2020

This issue is NOT covered by #193
#193 is about changing the product name from VSCodium to Codium.

This issue is about renaming the context menu entry 'Open with VSCodium' to 'Open with Codium'.

  • Which is 100% consistent with VSCode behavior
  • This is about consistency with VSCode and should not be made dependent on whether the VSCodium product name will (ever) be renamed to Codium. That is essentially unrelated.

Issue has not been fixed. Please reopen.

PRs are welcome if anyone wants to just get the context menu change into the next release.

Just proves that #369 has not (yet) been fixed.

@stripedpajamas
Copy link
Member

@lnlp #193 is about making VSCodium's naming conventions consistent with VSCode's naming conventions. This includes the context menu entry. You can see the same in the draft PR associated with #193. Specifically, the context menu entry sources its wording/name from the product.json file.

As I said, if anyone wants only this change before we figure out how to align all our naming conventions with VSCode's, PRs are welcome. We don't need separate issues for each place in the application where our naming conventions differ from upstream's.

@lnlp
Copy link
Author

lnlp commented Jun 10, 2020

#193 is about making VSCodium's naming conventions consistent with VSCode's naming conventions.

That is incorrect. #193 is not about making naming conventions consistent with VSCode. It is actually the opposite: remove "VS" from the VSCodium product name.
(I would appreciate the name change though.)

Inconsistency:

  • VSCode is named "VSCode" and its menu entry is named "Open with Code"
  • VSCodium is named VSCodium (with the same VS prefix as VSCode) but its menu entry is "Open with VSCodium" instead of "Open with Codium".

The inconsistency is that VSCode does not use the "VS" prefix in that menu but VSCodium does (and "Codium" just looks better).


There are two possible reasons for correcting the 'Open with' menu entry:

  1. To make it consistent with VSCode behavior as described above.
  2. If the VSCodium product name will be changed (e.g. to Codium) in future.

Reason 1. is VALID.
Reason 2. is currently invalid and it may never be. It will be valid only if the product name will be changed in future, which may never happen.

Fixing the menu entry inconsistency should not be made dependent on a possible future change of product name that may never happen. That is just incorrect. There currently already exists a valid reason to correct the menu entry and that is reason 1.

This issue should therefore be reopend (until it actually gets fixed).

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants