Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix insert mode for surrogate pairs #7977

Merged
merged 8 commits into from
Sep 25, 2022
Merged

Fix insert mode for surrogate pairs #7977

merged 8 commits into from
Sep 25, 2022

Conversation

garzj
Copy link

@garzj garzj commented Sep 20, 2022

What this PR does / why we need it:

When inserting surrogate pairs, for example emojis (Win + . / Ctrl + Cmd + ), it would show two "unknown glyph" characters.

Which issue(s) this PR fixes

Fixes #6046

J-Fields
J-Fields reviewed Sep 25, 2022
View reviewed changes
src/mode/modeData.ts Outdated Show resolved Hide resolved
J-Fields
J-Fields requested changes Sep 25, 2022
View reviewed changes
Copy link
Member

@J-Fields J-Fields left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than trivial issue of undefined vs. null. Thanks for the PR!

@J-Fields J-Fields mentioned this pull request Sep 25, 2022
Closed
@J-Fields J-Fields merged commit 4fbee0b into VSCodeVim:master Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-Fields J-Fields J-Fields approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Surrogate pairs (emojis, etc.) are not handled well in insert mode
2 participants
@garzj @J-Fields