-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: リサンプリングのパッケージをscipyからsoxrに変更 #749
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
approved these changes
Sep 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
ライセンスの部分だけコメントしました!
マージ後にテストビルドしてみたいと思います!
Co-authored-by: Hiroshiba <[email protected]>
マージします! |
おまたせしました、ビルドしてみました!! 試してみた感じ、普通にリサンプリングできていそうでした!! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
音声のリサンプリングに使用するパッケージを
SciPy
からsoxrに変更します。これによりWndows版のエンジンのファイルサイズが100MB程小さくなります。
その他
soxrにはクオリティの設定があります。
https://python-soxr.readthedocs.io/en/stable/soxr.html#soxr.resample
自分が聞く限りでは全く違いが分からなかったのでデフォルトのまま(
HQ
)にしましたが要確認だと思います。ライセンス自体は
LGPLv2.1+
なので問題はないはずです。ただ、
pip-licenses
が出力するライセンスのテキストがLGPLの本文のみ(これを検出している?)で含まれているライブラリのライセンスが含まれないようです。これをどのようにすればいいのか分かりません。