-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update_dictのリファクタリング #630
The head ref may contain hidden characters: "update_dict\u306E\u30EA\u30D5\u30A1\u30AF\u30BF\u30EA\u30F3\u30B0"
update_dictのリファクタリング #630
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
一時ファイルの削除操作まわりでちょっと気になった点を見つけたのでコメントしました(自分もちょっとよく分かっていないところがあるので、もし気にしすぎでしたらすみません)。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
コメントを追加しました
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!(1箇所だけ質問しましたが、多分大丈夫そうですかね……?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
(レビューありがとうございます!!) |
内容
update_dict
の処理が複雑化していたので、意図をコメントに書きつつ流れを整理しました。関連 Issue