-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Jinja2Templates
のDeprecationWarning
を解消
#1398
FIX: Jinja2Templates
のDeprecationWarning
を解消
#1398
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM👍️
TemplateResponse
の引数変更によりDeprecationWarning: The name is not the first parameter anymore.
が消失することを確認しました。nice!Jinja2Templates
の引数変更によりDeprecationWarning: Extra environment options are deprecated.
が消失することを確認しました。good work!- FastAPI 側であまり丁寧に説明されていない
directory
周りの移行が正しくおこなわれています。great!
- FastAPI 側であまり丁寧に説明されていない
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(レビュー抜けがありました🙇)
-
jinja2
の直接インポートによりpyproject.toml
のjinja2
に対する# NOTE: required by fastapi
が古い記述になったため、これを消す必要があります
@tarepan 修正しました。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM👍️
@sabonerune |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
なんか危ない記法だよなぁと思ってたのでこの変更はありがたいですね!!
pyproject.toml内のコメント、こちらでrevertさせていただきます!
内容
Jinja2Templates
周りのDeprecationWarning
を解消します。