-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
licenses.jsonの生成スクリプトを追加 #125
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
approved these changes
Sep 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! EULAの取得方法も明確でとても良さそうに感じました。
2点、とても細かい部分で気づいたことがあったので、ちょっと修正コミットを追加します。
Hiroshiba
reviewed
Sep 28, 2021
diff --git a/README.md b/README.md
--- README.md
+++ README.md
@@ -144,8 +144,9 @@
--include-package=uvicorn \
--include-package-data=pyopenjtalk \
--include-package-data=resampy \
--include-data-file=VERSION.txt=./ \
+ --include-data-file=licenses.json=./ \
--include-data-file=C:/path/to/cuda/*.dll=./ \
--include-data-file=C:/path/to/libtorch/*.dll=./ \
--include-data-file=C:/音声ライブラリへのパス/*.bin=./ \
--include-data-file=C:/音声ライブラリへのパス/metas.json=./ \
|
(実験報告です) |
This was referenced Sep 28, 2021
61 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
https://github.com/Hiroshiba/voicevox/issues/219#issuecomment-927917044 のコードをベースに、
ENGINEの依存関係のライセンス情報を格納したlicenses.jsonの生成スクリプトを追加します。
関連 Issue