Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency Rust to v1.77.0 #763

Merged
merged 4 commits into from
Mar 28, 2024
Merged

Update dependency Rust to v1.77.0 #763

merged 4 commits into from
Mar 28, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 21, 2024

Mend Renovate

This PR contains the following updates:

Package Update Change
Rust minor 1.76.0 -> 1.77.0

Release Notes

rust-lang/rust (Rust)

v1.77.0

Compare Source

==========================

Language

Compiler

Refer to Rust's [platform support page][platform-support-doc]
for more information on Rust's tiered platform support.

Libraries

Stabilized APIs

Cargo

Rustdoc

Misc

Internal Changes

These changes do not affect any public interfaces of Rust, but they represent
significant improvements to the performance or internals of rustc and related
tools.


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@qryxip
Copy link
Member

qryxip commented Mar 22, 2024

Clippyが落ちてるのは予定通りなのですが、他のはもしかしてcargo metadataの仕様が変わった…? (—format-version 1しているはずですが)

うーん、まだ見てないのですがpackage specがなんか変わったとか?
Package ID Specifications -The Cargo Book

@qryxip
Copy link
Member

qryxip commented Mar 22, 2024

まだPCに触れられていないので実物を見てないけど、多分これ。

This attempts to solve these problems by switching the id field from PackageId to PackageIdSpec which is a publicly documented format, can be generated by cargo pkgid, and is accepted by most commands via the --package flag.

As the "id" field is documented as opaque, this technically isn't a breaking change though people could be parsing it.

いやまあそれはそうだし、多分嬉しいケースは多いし致し方ないかも。cargo-denyが死んでるのは謎ですが。kratesって中で何やってるんだろ?

@qryxip
Copy link
Member

qryxip commented Mar 23, 2024

あーなるほど。GitのURLを取るためにidを文字列としてパースしてたと…
EmbarkStudios/krates#73

Copy link
Contributor Author

renovate bot commented Mar 23, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@qryxip
Copy link
Member

qryxip commented Mar 23, 2024

@Hiroshiba CIを通すために以下3点の変更を行いました。レビューお願いします。
(強制マージの権限は結局今私にありませんし)

  1. d847e74 (#763)
    jlabelを導入する #742 (comment)で導入したものに対し、とりあえずClippyが反応しないようにする。FIXMEに書いた通り、これを消すのは他のRust 1.77の新機能の導入と同時に行いたい。
  2. f0aada6 (#763)
    cargo metadataidのフォーマットに依存する行為はどうやらよくなかったようなので、反省して==比較以外に使わないようにする。
  3. 250987f (#763)
    cargo-denyをv0.13から、Fix git urls without specifiers EmbarkStudios/krates#73を含んだv0.14にアップデートする。

@qryxip qryxip requested a review from Hiroshiba March 23, 2024 15:29
@Hiroshiba
Copy link
Member

Hiroshiba commented Mar 28, 2024

@qryxip 見てみました、わかんないけど問題ない気がしました!

強制マージの権限は結局今私にありませんし

おっとなるほどです!!

なにかのタイミングでVOICEVOX/maintainerから @qryxip さんを外した関係でフォースマージ権限がなくなったんだと思います。
VOICEVOX/core-maintainerにも権限を付与してみたのフォンスマージできるか確かめてもらっても良いでしょうか?

@qryxip qryxip merged commit 392e5e4 into main Mar 28, 2024
65 checks passed
@qryxip qryxip deleted the renovate/rust branch March 28, 2024 01:23
@qryxip
Copy link
Member

qryxip commented Mar 28, 2024

できました。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants