example下の"speaker_id"を、"style_id"に直す #562 #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
READMEの記述というと？
これなら消さない方がいいと思いますね、 #582 などの破壊的変更の議論もありますし |
|
example/python/README.mdの ここと voicevox_core/example/python/README.md Line 55 in e571d70 ここです voicevox_core/example/python/README.md Line 66 in e571d70 |
|
あ、それは更新するべきですね（ |
Hiroshiba
reviewed
Aug 26, 2023
| uintptr_t output_binary_size = 0; | ||
| uint8_t* output_wav = nullptr; | ||
| VoicevoxTtsOptions ttsOptions = voicevox_make_default_tts_options(); | ||
|
|
||
| result = voicevox_synthesizer_tts(synthesizer,wide_to_utf8_cppapi(speak_words).c_str(), speaker_id, ttsOptions, &output_binary_size, &output_wav); | ||
| result = voicevox_synthesizer_tts(synthesizer,wide_to_utf8_cppapi(speak_words).c_str(),p style_id, ttsOptions, &output_binary_size, &output_wav); |
Hiroshiba
approved these changes
Aug 26, 2023
sevenc-nanashi
requested changes
Aug 26, 2023
| uintptr_t output_binary_size = 0; | ||
| uint8_t* output_wav = nullptr; | ||
| VoicevoxTtsOptions ttsOptions = voicevox_make_default_tts_options(); | ||
|
|
||
| result = voicevox_synthesizer_tts(synthesizer,wide_to_utf8_cppapi(speak_words).c_str(), speaker_id, ttsOptions, &output_binary_size, &output_wav); | ||
| result = voicevox_synthesizer_tts(synthesizer,wide_to_utf8_cppapi(speak_words).c_str(),style_id, ttsOptions, &output_binary_size, &output_wav); |
There was a problem hiding this comment.
Suggested change
| result = voicevox_synthesizer_tts(synthesizer,wide_to_utf8_cppapi(speak_words).c_str(),style_id, ttsOptions, &output_binary_size, &output_wav); | |
| result = voicevox_synthesizer_tts(synthesizer,wide_to_utf8_cppapi(speak_words).c_str(), style_id, ttsOptions, &output_binary_size, &output_wav); |
空白を入れるべきだと思います
sevenc-nanashi
approved these changes
Aug 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
#562
関連 Issue
ref #562
その他
README.mdの記載も変える必要がありますか？