キャラクター並び替えダイアログ: スタイルごとにアイコンを変える #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
キャラクター並び替えダイアログ（CharacterOrderDialog）について、スタイルを切り替えたときに、アイコンをスタイルに対応するものに切り替えるようにします。
複数エンジン対応中に気になったのでPRを作成しました。
（キャラクター並び替えダイアログではデフォルトスタイルが変更されないので、意図的にアイコンを切り替えていないのかも・・・？ その場合はCloseしてください）
これまでの実装では、常に0番目のスタイルのアイコンが表示されていました。
#754 の変更と互換性があります。
関連 Issue
スクリーンショット・動画など
その他