[HOTFIX(for developer)]add publish option (fixed repo, remove version's "v") #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y-chan
changed the title
Hiroshiba
approved these changes
Sep 20, 2021
Hiroshiba
reviewed
Sep 20, 2021
|
お手数をおかけして申し訳ありません。 |
y-chan
changed the title
Hiroshiba
added a commit
that referenced
this pull request
Sep 21, 2021
* To 0.6.0 (#242) * update openapi * update updateInfos.json * update htu * update design * update version * [HOTFIX(for developer)]add publish option (fixed owner and repo, remove version's "v") (#245) * add publish option (fixed owner and repo, remove version's "v") * Apply suggestions from code review Co-authored-by: Hiroshiba <[email protected]> Co-authored-by: Yuto Ashida <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
vue.config.jsにpublishを追加し、publish場所を固定(installer.nsh内のAPP_PACKAGE_URLが、ビルドリポジトリに影響されることなく、固定される)。さらに、
installer.nsh内のAPP_PACKAGE_URLにversion値としてvが入ることを抑止(vPrefixedTagNameオプションをfalseに)この設定により、
どんな環境でビルドされても、nsis-webが見に行くダウンロード元が固定されます。nsis-webが見に行くダウンロード元リポジトリ名が定まります。(今後インストーラーのテストがしやすいように、ownerは固定していません)関連 Issue
ref #210
ref #244