Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.22] Fix: インポート時のトラック順を修正 #2415

Merged
merged 2 commits into from
Dec 15, 2024

Conversation

sevenc-nanashi
Copy link
Member

内容

10個以上のトラックをインポートするときにインポート時にトラック順が壊れていたのを修正します。
また、引数なしsortをESLintで禁止します。

関連 Issue

(なし)

スクリーンショット・動画など

(なし)

その他

(なし)

@sevenc-nanashi sevenc-nanashi requested a review from a team as a code owner December 14, 2024 10:39
@sevenc-nanashi sevenc-nanashi requested review from Hiroshiba and removed request for a team December 14, 2024 10:39
@sevenc-nanashi sevenc-nanashi force-pushed the fix/import-track-order-ten branch from abb5336 to daa0863 Compare December 14, 2024 10:40
@sevenc-nanashi sevenc-nanashi changed the base branch from main to release-0.22 December 14, 2024 10:40
@sevenc-nanashi sevenc-nanashi changed the title Fix: インポート時のトラック順を修正 [release-0.22] Fix: インポート時のトラック順を修正 Dec 14, 2024
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

このESLintはあったほうが良さそうですね!
なぜtypescript-eslintのrecommendedに含まれてないんだろう。

@Hiroshiba
Copy link
Member

まだmainブランチにコミットが増えてなかったので、mainブランチにマージした後release-0.22で追従したいと思います!

@Hiroshiba Hiroshiba changed the base branch from release-0.22 to main December 15, 2024 04:58
@Hiroshiba Hiroshiba merged commit 84bd237 into VOICEVOX:main Dec 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants