Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: nodeのpathをimportしていたところが残っていたのを直す #2408

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

sevenc-nanashi
Copy link
Member

内容

nodeのpathをimportしていたところが残っていたのを直します。

関連 Issue

(なし)

スクリーンショット・動画など

(なし)

その他

(なし)

@sevenc-nanashi sevenc-nanashi requested a review from a team as a code owner December 10, 2024 11:34
@sevenc-nanashi sevenc-nanashi requested review from Hiroshiba and removed request for a team December 10, 2024 11:34
@voicevox-preview-pages
Copy link

🚀 プレビュー用ページを作成しました 🚀

更新時点でのコミットハッシュ:1b6b9db

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

小さいpr助かります!

import時にnode:を必須にするのありかもと思ったのですが、よく考えるとelectronやtestのとこはnode:だらけにしないといけず大変かも…?
そうでもなさそうなら導入して良さそうな気もしました!

@Hiroshiba Hiroshiba merged commit f4982e9 into VOICEVOX:main Dec 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants