fix: ソングの編集ツールのアイコンが読み込まれていないときに表示が崩れるのを修正する #2405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
changed the title
|
🚀 プレビュー用ページを作成しました 🚀 更新時点でのコミットハッシュ： |
sevenc-nanashi
approved these changes
Dec 10, 2024
Hiroshiba
commented
Dec 13, 2024
There was a problem hiding this comment.
レビューありがとうございます！
マージします！
@romot-co さんにも一応メンションまで･･･！
ちなみにquasarのQIconもMaterial Symbolsに対応していそうな感じでした 🙏
https://quasar.dev/vue-components/icon/#:~:text=Material%20Icons%20%2C-,Material%20Symbols,-%2C%20Font%20Awesome
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
ソングの編集ツールのアイコンが読み込まれていないときに表示が崩れるのを修正します。
フォントが読み込まれてない間、元の文字列が表示されていました。
これを表示されないように（block）し、空欄になってもなお横幅は取られてしまうっぽいのでmax-widthをフォントサイズと同じサイズにしました。
後々コンポーネント化してもいいかも。
関連 Issue