Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: スナップショットの制約をきつくする #2399

Conversation

Hiroshiba
Copy link
Member

内容

たぶん制約が緩められているのですが、もしかしたらこれが原因で見逃しが結構あるかもと思ったのでなくしてみます。
とりあえずDraftで。

その他

@Hiroshiba Hiroshiba requested a review from a team as a code owner December 7, 2024 20:00
@voicevox-preview-pages
Copy link

voicevox-preview-pages bot commented Dec 7, 2024

🚀 プレビュー用ページを作成しました 🚀

更新時点でのコミットハッシュ:075f44f

Copy link
Member Author

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

問題なさそう・・・・・・・?

@Hiroshiba
Copy link
Member Author

レビューありがとうございます!
windowsのスナップショットももしかしたらflakyかもですが、それ含めて様子見ということで…!

マージします!

@Hiroshiba Hiroshiba merged commit 4633856 into VOICEVOX:main Dec 8, 2024
10 checks passed
@Hiroshiba Hiroshiba deleted the スナップショットの制約をきつくしてみる branch December 8, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants