マルチトラック：インポートに対応 #2126
Merged
マルチトラック：インポートに対応 #2126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
approved these changes
Jun 20, 2024
Comment on lines
-284
to
+306
| if (project.value == null || selectedTrack.value == null) { | ||
| if (project.value == null || selectedTrackIndexes.value == null) { |
There was a problem hiding this comment.
他と合わせて、空っぽのときもエラーでも良いかも
（そのままでも良いかも）
このあたりの処理（disableになってるかとか）をstorybook辺りでテスト書けるとかっこいいかもですね
src/store/singing.ts
Outdated
Comment on lines
117
to
118
| const isTracksEmpty = (tracks: Map<TrackId, Track>) => | ||
| tracks.size === 1 && [...tracks.values()][0].notes.length === 0; |
There was a problem hiding this comment.
こういうのがいっぱい詰め込まれたutitliyあった記憶。
そちらに似た関数あればそちらに書くほうがまとまり良いかも。
あとsize==0のときもempty判定で良いかも？
There was a problem hiding this comment.
sing/domain.tsにisValid系がたくさんありましたが、Map<TrackId, Tracks>を使ってるのはここくらいしかないのでここに置くのがいいかな～って感じでした。
There was a problem hiding this comment.
domain.tsに置くとsinging.tsがすっきりするので、domain.tsに置いても良いと思います。
また、この関数ではkey（TrackId）は必要ないので、引数の型はTrack[]でも良いかもです。
isTrackEmpty: (track: Track) => booleanにして
tracksArray.length === 1 && isTrackEmpty(tracksArray[0])でも良いかも。
Hiroshiba
reviewed
Jun 20, 2024
Hiroshiba
approved these changes
Jun 30, 2024
| startFrame: 0, | ||
| trackId, | ||
| }); | ||
| // 色々な処理を動かすため、二重にセットする |
There was a problem hiding this comment.
ここも忘れないようにTODOコメント入れさせていただきます 🙇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
インポートをマルチトラックに対応させます。
関連 Issue
スクリーンショット・動画など
その他
（なし）