Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ソング:矩形選択を追加 #1911

Merged
merged 12 commits into from
Mar 13, 2024

Conversation

sevenc-nanashi
Copy link
Member

@sevenc-nanashi sevenc-nanashi commented Mar 6, 2024

内容

矩形選択を追加します。

関連 Issue

スクリーンショット・動画など

sozai.vvproj.-.VOICEVOX.-.Ver.999.999.999.ubuntu.2024-03-06.20-55-47.mp4

その他

(なし)

@sevenc-nanashi sevenc-nanashi marked this pull request as ready for review March 6, 2024 11:57
@sevenc-nanashi sevenc-nanashi requested a review from a team as a code owner March 6, 2024 11:57
@sevenc-nanashi sevenc-nanashi requested review from Hiroshiba and removed request for a team March 6, 2024 11:57
Copy link
Contributor

@sigprogramming sigprogramming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

矩形選択の実装ありがとうございます!

src/components/Sing/ScoreSequencer.vue Outdated Show resolved Hide resolved
src/components/Sing/ScoreSequencer.vue Outdated Show resolved Hide resolved
src/components/Sing/ScoreSequencer.vue Outdated Show resolved Hide resolved
src/components/Sing/ScoreSequencer.vue Outdated Show resolved Hide resolved
@sevenc-nanashi
Copy link
Member Author

レビューを反映しました。

@sevenc-nanashi
Copy link
Member Author

レビューを反映しました。

Copy link
Contributor

@sigprogramming sigprogramming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Copy link
Contributor

@romot-co romot-co left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

矩形選択の実装ありがとうございます!
LGTMです!!

@sevenc-nanashi
Copy link
Member Author

Approve2個集まったのでマージしたいと思います、ありがとうございました!

@Hiroshiba 割と求めてる人が多そうな機能なので(時間がある時に)ツイートしてもいいかも?

@sevenc-nanashi sevenc-nanashi merged commit bb8aca8 into VOICEVOX:main Mar 13, 2024
9 checks passed
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ツイートしておこうと思います!

ちょっとこのScoreSequencer.vueが本当に大きくなっていて、多分もういくつか不安定な挙動がある気がします。
リファクタリング進めていかないと大変なことになりそう・・・・。
コンポーザブルとか導入すれば少なくとも切り分けられないですかね・・・。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ソング:矩形選択を作る
4 participants