Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1877 ソング: 編集メニューの追加とノートのコピー&ペーストの実装 #1903
#1877 ソング: 編集メニューの追加とノートのコピー&ペーストの実装 #1903
Changes from 9 commits
8765ec6
17df062
77d20a4
b85c7e1
9dc76d0
0cd340e
ee42219
37797e8
48dcdce
842e8f3
7423298
7f277ef
3438da1
0c3bafb
32f87c4
e1f1de9
0def4f5
7f068bd
15d2de6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
なるほどです!!
ここにisMacがあるのでそれも加えるといいかも?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ちょっと考えたのですが同意見です!
よくある挙動だとコンテキストメニュー開いた後のクリックも普通のクリックと同じ扱いにする(ボタンを押すなど)のですが、どこをクリックしても何かが発動するシーケンサーの場合は話は別なのかなぁと思いました。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
この2つはsingとtalkで同じなので統一できそうですね!!
実際に「プロジェクト上書き保存」とかは
BaseMenuBar
内で統一されてるので、書き方を真似れば統一できると思います!voicevox/src/components/Menu/MenuBar/BaseMenuBar.vue
Lines 299 to 307 in 0c3bafb
分からなかったら後でプルリクエスト出させていただきます!