Change: zodを使うように #1078
Merged
Change: zodを使うように #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
requested review from
a team and
Hiroshiba
and removed request for
a team
Hiroshiba
reviewed
Jan 2, 2023
Hiroshiba
reviewed
Jan 2, 2023
Hiroshiba
reviewed
Jan 2, 2023
Hiroshiba
reviewed
Jan 4, 2023
| } | ||
| import { z } from "zod"; | ||
|
|
||
| export const isMac = process.platform === "darwin"; |
There was a problem hiding this comment.
| default: [], | ||
| }, | ||
| }, | ||
| schema: electronStoreJsonSchema.properties as Schema<ElectronStoreType>, |
There was a problem hiding this comment.
ここのasを取るいい方法考えてみたのですが思いつきませんでした 😇
zodToJsonSchemaが型消しちゃうんですねぇ
Co-authored-by: Hiroshiba <[email protected]>
Co-authored-by: Hiroshiba <[email protected]>
Hiroshiba
requested review from
MT224244 and
y-chan
and removed request for
MT224244
|
多分大丈夫だと思うのと、時間が経つほどコンフリクトが発生しやすい分野だと思うので、マージしちゃいます！！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
タイトル通り。
関連 Issue
スクリーンショット・動画など
（なし）
その他
サンプリングレートをdefaultからengineDefaultにしないと動かないと思います。（#1056のブランチから始めるべきだった…）