Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use onnxruntime-1.17.3 #13

Merged
merged 2 commits into from
Feb 15, 2025

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Feb 12, 2025

内容

関連 Issue

Refs: VOICEVOX/onnxruntime-builder#41, VOICEVOX/onnxruntime-builder#56
Refs: VOICEVOX/onnxruntime-builder#44, VOICEVOX/onnxruntime-builder#47
Refs: VOICEVOX/onnxruntime-builder#51
Refs: VOICEVOX/onnxruntime-builder#73, VOICEVOX/onnxruntime-builder#74
See-also: VOICEVOX/onnxruntime-builder@1.17.3...onnxruntime-1.17.3

スクリーンショット・動画など

その他

ちなみにこうやって確認しました。

# ファイル名の一致の確認diff \<(cat ort-sys/dist.txt | cut -f 3 | awk -F / '{print $NF}') \<(sha256sum ~/Downloads/onnxruntime-*.tgz | cut -d ' ' -f 3 | awk -F / '{print $NF}')
# SHA-256の一致の確認diff \<(cat ort-sys/dist.txt | cut -f 4) \<(sha256sum ~/Downloads/onnxruntime-*.tgz | cut -d ' ' -f 1 | tr a-z A-Z)

@qryxip qryxip requested a review from Hiroshiba February 12, 2025 08:04
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pykeio/ortとの差分を最小にする試みをこれまでしていたが、多分無意味であるためこのファイルについてはやめる。

@qryxip
Copy link
Member Author

qryxip commented Feb 12, 2025

VOICEVOX/voicevox_core#1003

そろそろdownload_testを直さないと…

@qryxip
Copy link
Member Author

qryxip commented Feb 13, 2025


あ、ちなみにCIが永久にpendingになってるのは、macos-12だからですね…

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@qryxip qryxip merged commit 1ebb576 into VOICEVOX:main Feb 15, 2025
4 of 5 checks passed
@qryxip qryxip deleted the pr/feat-use-onnxruntime-1-17-3 branch February 15, 2025 17:23
qryxip added a commit to VOICEVOX/voicevox_core that referenced this pull request Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants