feat: Windows環境でFILE_FLAG_DELETE_ON_CLOSEを付けて開かれている辞書を扱えるようにする
#13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
reviewed
Jan 14, 2025
src/mecab/src/mmap.h
Outdated
| @@ -107,7 +107,7 @@ template <class T> class Mmap { | |||
| #if 0 /* for Open JTalk */ | |||
| hFile = ::CreateFileA(filename, mode1, FILE_SHARE_READ, 0, | |||
There was a problem hiding this comment.
こっちも変えとくのどうでしょう？ 👀
こう？
Suggested change
| hFile = ::CreateFileA(filename, mode1, FILE_SHARE_READ, 0, | |
| hFile = ::CreateFileA(filename, mode1, FILE_SHARE_READ | FILE_SHARE_DELETE, 0, |
Hiroshiba
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
CreateFileW関数のdwShareModeにFILE_SHARE_DELETEを追加します。これによりプロセス終了時や辞書切り替え時にユーザー辞書を自動的に削除することが可能になります。
詳細は VOICEVOX/voicevox_engine#1347 (comment) を参照。
関連 Issue
その他
CreateFileW