Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document drag'n'drop #330

Merged
merged 16 commits into from
Mar 2, 2024

Test publisher

ff3ca68
Select commit
Loading
Failed to load commit list.
Merged

Document drag'n'drop #330

Test publisher
ff3ca68
Select commit
Loading
Failed to load commit list.
Xcode Cloud / VoiceOver Designer | Designer: UI-tests | Test - macOS succeeded Jan 23, 2024 in 5m 1s

12 warnings

Report Summary
Errors 0
Test Failures 0
Analysis Issues 0
Warnings 12

Details

12 Warnings

Details

  VoiceOverDesignerUITests/PageObjects/Panels/Settings.swift:115
      Variable 'textField' was never mutated; consider changing to 'let' constant
  Shared/Sources/Document/Accessibility/Protocols/AccessibilityView/Artboard+Grouping.swift:70
      String interpolation produces a debug description for an optional value; did you mean to make this explicit?
  Shared/Sources/TextRecognition/TextRecognitionService.swift:75
      'languageCode' was deprecated in macOS 13: renamed to 'language.languageCode.identifier'
  VoiceOverDesignerUITests/PageObjects/Panels/Settings.swift:134
      Variable 'addCustomDescriptionButton' was never mutated; consider changing to 'let' constant
  The CFBundleVersion of an app extension ('3') must match that of its containing parent app ('22').
  VoiceOverDesignerUITests/PageObjects/Panels/Settings.swift:111
      Variable 'addCustomActionButton' was never mutated; consider changing to 'let' constant
  Shared/Sources/Canvas/Drawing/DrawingController.swift:229
      Treating a forced downcast to 'CGImage' as optional will never produce 'nil'
  VoiceOver Designer/Features/Sources/CanvasAppKit/CanvasViewController.swift:186
      'allowedFileTypes' was deprecated in macOS 12.0: Use -allowedContentTypes instead
  VoiceOver Designer/Features/Sources/Recent/RecentViewController/Domain/UserDocuments/UserDocumentsPresenter.swift:121
      TODO: Find a way to access document url otherwise cannot rename
  VoiceOver Designer/Features/Sources/Recent/Collection/DocumentCellViewItem.swift:97
      Non-sendable type 'Image?' (aka 'Optional') returned by implicitly asynchronous call to nonisolated function cannot cross actor boundary
  Shared/Sources/TextRecognition/TextRecognitionService.swift:61
      'supportedRecognitionLanguages(for:revision:)' was deprecated in macOS 12.0
  Shared/Sources/Document/Accessibility/Array+Move.swift:53
      Result of call to 'remove' is unused

Annotations

Check notice on line 186 in VoiceOver Designer/Features/Sources/CanvasAppKit/CanvasViewController.swift

See this annotation in the file changed.

@xcode-cloud xcode-cloud / VoiceOver Designer | Designer: UI-tests | Test - macOS

VoiceOver Designer/Features/Sources/CanvasAppKit/CanvasViewController.swift#L186

'allowedFileTypes' was deprecated in macOS 12.0: Use -allowedContentTypes instead