Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redo for several actions #310

Merged
merged 1 commit into from
Nov 19, 2023

Add redo for several actions

ca7b26b
Select commit
Loading
Failed to load commit list.
Merged

Add redo for several actions #310

Add redo for several actions
ca7b26b
Select commit
Loading
Failed to load commit list.
Xcode Cloud / VoiceOver Designer | Test Designer | Test - macOS succeeded Nov 19, 2023 in 4m 8s

29 warnings

Report Summary
Errors 0
Test Failures 0
Analysis Issues 0
Warnings 29

Details

29 Warnings

Details

  Shared/Sources/Document/Documents/Document/VODesignDocumentProtocol.swift:67
      Enum case 'cache' has 2 associated values; matching them as a tuple is deprecated
  VoiceOver Designer/Features/Sources/Navigator/NavigatorController+Dragging.swift:56
      'controls' is deprecated: Use `artboard`
  Shared/Sources/Artboard/Artboard.swift:127
      Immutable value 'image' was never used; consider replacing with '_' or removing it
  VoiceOver Designer/Features/Sources/Recent/RecentViewController/Domain/UserDocuments/UserDocumentsPresenter.swift:121
      TODO: Find a way to access document url otherwise cannot rename
  Shared/Sources/Document/Accessibility/DocumentPresenter.swift:144
      'controls' is deprecated: Use `artboard`
  VoiceOver Designer/Features/Sources/Recent/Collection/DocumentCellViewItem.swift:97
      Non-sendable type 'Image?' (aka 'Optional') returned by implicitly asynchronous call to nonisolated function cannot cross actor boundary
  Shared/Sources/Document/Accessibility/DocumentPresenter.swift:137
      'controls' is deprecated: Use `artboard`
  Shared/Sources/TextRecognition/TextRecognitionService.swift:73
      'languageCode' was deprecated in macOS 13: renamed to 'language.languageCode.identifier'
  VoiceOver Designer/Features/Sources/Presentation/PresentationView.swift:116
      Immutable value 'frame' was never used; consider replacing with '_' or removing it
  VoiceOver Designer/Features/Sources/Navigator/NavigatorController+Dragging.swift:50
      'controls' is deprecated: Use `artboard`
  Shared/Sources/Document/Documents/Document/VODesignDocument+FileWrapper.swift:29
      Value 'existedWrapper' was defined but never used; consider replacing with boolean test
  Shared/Sources/Document/Accessibility/DocumentPresenter.swift:151
      'controls' is deprecated: Use `artboard`
  The CFBundleVersion of an app extension ('3') must match that of its containing parent app ('22').
  VoiceOver Designer/Features/Sources/Recent/RecentViewController/Domain/UserDocuments/UserDocumentsPresenter.swift:22
      Left side of nil coalescing operator '??' has non-optional type '[URL]', so the right side is never used
  Shared/Sources/Canvas/Drawing/DrawingController.swift:229
      Treating a forced downcast to 'CGImage' as optional will never produce 'nil'
  VoiceOver Designer/Features/Sources/Navigator/NavigatorController+Dragging.swift:38
      'controls' is deprecated: Use `artboard`
  VoiceOver Designer/Features/Sources/CanvasAppKit/CanvasViewController.swift:189
      'allowedFileTypes' was deprecated in macOS 12.0: Use -allowedContentTypes instead
  Shared/Sources/Document/Documents/Document/VODesignDocument+FileWrapper.swift:197
      String interpolation produces a debug description for an optional value; did you mean to make this explicit?
  Shared/Sources/Document/Documents/Document/VODesignDocument+FileWrapper.swift:42
      Immutable value 'url' was never used; consider replacing with '_' or removing it
  VoiceOver Designer/Features/Sources/CommonUI/DragNDropImageView.swift:77
      Initialization of immutable value 'centeredOrigin' was never used; consider replacing with assignment to '_' or removing it
  file:///Volumes/workspace/DerivedData/SourcePackages/checkouts/swift-custom-dump/Sources/CustomDump/Dump.swift:64
      Generic parameter 'T' shadows generic parameter from outer scope with the same name; this is an error in Swift 6
  file:///Volumes/workspace/DerivedData/SourcePackages/checkouts/xctest-dynamic-overlay/Sources/XCTestDynamicOverlay/Internal/RuntimeWarnings.swift:15
      Cannot use conformance of 'String' to 'CVarArg' here; 'Foundation' was not imported by this file; this is an error in Swift 6
  Shared/Sources/Document/Documents/Document/VODesignDocumentProtocol.swift:65
      Immutable value 'url' was never used; consider replacing with '_' or removing it
  Shared/Tests/DocumentTests/Persistance/FrameInfoCodableTests.swift:11
      Code after 'throw' will never be executed
  Shared/Sources/Document/Documents/Document/ImageLoader.swift:24
      Immutable value 'name' was never used; consider replacing with '_' or removing it
  VoiceOver Designer/Features/Tests/CanvasAppKitTests/Base/XCTestCase.Publisher.swift:45
      Instance method 'wait' is unavailable from asynchronous contexts; Use await fulfillment(of:timeout:enforceOrder:) instead; this is an error in Swift 6
  Shared/Sources/Document/Documents/Document/VODesignDocument+Controls.swift:5
      'controls' is deprecated: Use `artboard`
  file:///Volumes/workspace/DerivedData/SourcePackages/checkouts/swift-custom-dump/Sources/CustomDump/Dump.swift:64
      Generic parameter 'TargetStream' shadows generic parameter from outer scope with the same name; this is an error in Swift 6
  Shared/Sources/TextRecognition/TextRecognitionService.swift:60
      'supportedRecognitionLanguages(for:revision:)' was deprecated in macOS 12.0

Annotations

Check notice on line 144 in Shared/Sources/Document/Accessibility/DocumentPresenter.swift

See this annotation in the file changed.

@xcode-cloud xcode-cloud / VoiceOver Designer | Test Designer | Test - macOS

Shared/Sources/Document/Accessibility/DocumentPresenter.swift#L144

'controls' is deprecated: Use `artboard`

Check notice on line 137 in Shared/Sources/Document/Accessibility/DocumentPresenter.swift

See this annotation in the file changed.

@xcode-cloud xcode-cloud / VoiceOver Designer | Test Designer | Test - macOS

Shared/Sources/Document/Accessibility/DocumentPresenter.swift#L137

'controls' is deprecated: Use `artboard`

Check notice on line 151 in Shared/Sources/Document/Accessibility/DocumentPresenter.swift

See this annotation in the file changed.

@xcode-cloud xcode-cloud / VoiceOver Designer | Test Designer | Test - macOS

Shared/Sources/Document/Accessibility/DocumentPresenter.swift#L151

'controls' is deprecated: Use `artboard`