Artboards structure #254

akaDuality · 2023-04-09T17:11:48Z

Closes #253

Fix position

VoiceOver Preview/PreviewFeatures/Sources/DesignPreview/Main/PreviewMainViewController.swift

Somehow new swift 5.8 implicit self doesn't work with combination of if let syntax

akaDuality added 14 commits April 9, 2023 14:10

Extract content view subclass

a9b4150

Set frame outside of image function

ae5586a

Do not flip coordinates

e17c2ee

Fix text recognition from image

4e963ed

Remove code

5938b03

Move frames to document

06e507e

Refactor image fitting

2a98866

Read stubbed file

bf47dcb

Add controls to Frame

254a576

Rework file saving to support frames

c84b3b0

Fix selection

4d4b91f

Rename document to AppleDocument

3a0c6a0

Wrap frames in Artboard domain object

8bc6138

Present frames at navigator

c272d17

akaDuality added the enhancement New feature or request label Apr 9, 2023

akaDuality added this to the 2.0 Figma integration milestone Apr 9, 2023

akaDuality self-assigned this Apr 9, 2023

akaDuality added 13 commits April 15, 2023 15:56

Fix test’s build

3f65197

Refactor cursors

ebaa4ff

Draw background images of frames on CALayer

24a67c5

Restore image recognition

c3c69bb

Fix tests

7fe5248

Use artboard to publish events

dafc827

Test: when add image it creates a frame

6633178

Disable tests and mark code as deprecated

2e099bc

Remove image property from document

f025c12

When draw an element inside frame should add to frames

ccae145

Rename frame’s controls to elements

1437384

Rearrange files

fd23186

Extract Artboard package

d04c623

akaDuality added 6 commits May 6, 2023 20:15

Simplify couple of tests

d4e0039

Restore document persistance tests

8c73cd2

Fix translating tests

c12e7df

Fix CanvasUpdatingTests

9ade85e

Add empty file to allow target creation

607b6cf

Fix build for Preview

46971a9

akaDuality requested a review from drucelweisse May 7, 2023 16:11

akaDuality added 4 commits May 7, 2023 13:13

Fix build of Preview’s test

6283ed9

Fix build for preview

ce8ac7c

Can fit scale according to width and height

042574b

Fix position

Move elements inside container during MoveAction

374fc7b

drucelweisse approved these changes May 8, 2023

View reviewed changes

akaDuality added 8 commits May 8, 2023 09:47

Allow to select frame

45da205

Add encoding for containers

931ff46

Read file in artboard format

c8af3fc

Add support for 3 version of files

5dacadd

Fix image loading for all formats

5df9f07

Add shared constructor for Image from data

2117ff0

Fix build for Preview

4cd47e7

Update gitignore

0a76201

drucelweisse reviewed May 9, 2023

View reviewed changes

VoiceOver Preview/PreviewFeatures/Sources/DesignPreview/Main/PreviewMainViewController.swift Outdated Show resolved Hide resolved

drucelweisse and others added 3 commits May 9, 2023 15:45

fix compile error within closure

272ac27

Somehow new swift 5.8 implicit self doesn't work with combination of if let syntax

Support relative path for images

4888d10

Add thumbnail test for artboard

be23471

akaDuality marked this pull request as ready for review May 9, 2023 21:13

akaDuality changed the base branch from main to develop May 9, 2023 23:03

akaDuality changed the title ~~Artboards~~ Artboards structure May 9, 2023

akaDuality merged commit 24c0ec3 into develop May 9, 2023

akaDuality deleted the artboards branch May 9, 2023 23:09

akaDuality mentioned this pull request May 9, 2023

Draw elements without image #256

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Artboards structure #254

Artboards structure #254

akaDuality commented Apr 9, 2023

Artboards structure #254

Artboards structure #254

Conversation

akaDuality commented Apr 9, 2023