Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vkBase, Paradigm): New tokens #1155

Merged
merged 14 commits into from
Dec 27, 2024
Merged

feat(vkBase, Paradigm): New tokens #1155

merged 14 commits into from
Dec 27, 2024

Conversation

qurle
Copy link
Contributor

@qurle qurle commented Dec 23, 2024

  • Добавлен токен sizeCellHeight, colorStrokeColorPrimary, colorBackgroundContentAlpha и sizeButtonExtraSmallHeight в темы vkBase и paradigm (затрагивает все темы).
  • Починены наследования в интерфейсах тем vkIdOkIOS и vkAccessibilityIOS. Не затрагивает иных изменений

@qurle qurle requested a review from a team as a code owner December 23, 2024 17:35
@qurle qurle marked this pull request as draft December 24, 2024 08:20
@qurle qurle marked this pull request as draft December 24, 2024 08:20
@qurle
Copy link
Contributor Author

qurle commented Dec 24, 2024

Занести всё в базовую тему, окнуть с @VKCOM/vkui-design и @Fliqle

@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.72%. Comparing base (ed80609) to head (2dfae30).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ions/themes/lego/helpers/overwriteFromFigmaJSON.ts 66.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1155       +/-   ##
===========================================
+ Coverage        0   91.72%   +91.72%     
===========================================
  Files           0       86       +86     
  Lines           0     1450     +1450     
  Branches        0      261      +261     
===========================================
+ Hits            0     1330     +1330     
- Misses          0      120      +120     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qurle qurle changed the title feat(vkBase, Paradigm, vkIOS, vkontakteAndroid): New tokens feat(vkBase, Paradigm): New tokens Dec 26, 2024
@qurle qurle marked this pull request as ready for review December 26, 2024 17:20
@SevereCloud SevereCloud merged commit 81f48f0 into master Dec 27, 2024
4 checks passed
@qurle qurle deleted the qurle/feat/lego-update branch December 27, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants