refactor(useOrientationChange): rm useGlobalEventListener; make SSR ready #7811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eady - SSR: инициализируем как `'portrait'`, а в эффекте меняем значение на актуальное - useGlobalEventListener: избавляемся, чтобы облегчить хук от лишних операций - покрываем тестами - реэкспоритурем тип `Orientation`
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests
|
👀 Docs deployed
Commit 7da0c44 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7811 +/- ##
==========================================
+ Coverage 95.08% 95.09% +0.01%
==========================================
Files 376 376
Lines 11074 11079 +5
Branches 3677 3676 -1
==========================================
+ Hits 10530 10536 +6
+ Misses 544 543 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
EldarMuhamethanov
approved these changes
Oct 22, 2024
|
Note
Это флакнуло два скриншота на |
BlackySoul
approved these changes
Oct 23, 2024
inomdzhon
deleted the
imirdzhamolov/feat/refactor-useOrientationChange
branch
| ✅ v7.0.0-beta.1 🎉 |
| ✅ v7.0.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
'portrait', а в эффекте меняем значение на актуальноеOrientationRelease notes
Улучшения
Orientation.