feat(Banner): rename prop asideMode to after and add prop tappable
#7793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
👀 Docs deployed
Commit 8f45609 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7793 +/- ##
==========================================
+ Coverage 95.08% 95.10% +0.01%
==========================================
Files 376 376
Lines 11074 11076 +2
Branches 3677 3679 +2
==========================================
+ Hits 10530 10534 +4
+ Misses 544 542 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
inomdzhon
reviewed
Oct 21, 2024
inomdzhon
reviewed
Oct 21, 2024
inomdzhon
previously approved these changes
Oct 22, 2024
SevereCloud
reviewed
Oct 22, 2024
# Conflicts: # packages/vkui/src/components/Banner/__image_snapshots__/banner-vkcom-chromium-light-1-snap.png # packages/vkui/src/components/Banner/__image_snapshots__/banner-vkcom-firefox-light-1-snap.png # packages/vkui/src/components/Banner/__image_snapshots__/banner-vkcom-webkit-light-1-snap.png
inomdzhon
previously approved these changes
Oct 22, 2024
SevereCloud
reviewed
Oct 22, 2024
SevereCloud
approved these changes
Oct 22, 2024
inomdzhon
approved these changes
Oct 22, 2024
EldarMuhamethanov
deleted the
e.muhamethanov/7755/banner-rename-aside-mode
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
В компоненте
Bannerпереименовал свойствоasideModeнаafter. Также сделал корневой элемент через Tappable.Release notes
BREAKING CHANGE
Banner: свойство
asideModeпереименовано наafterПример миграции
<Banner before={<Avatar size={48} src={'user_lihachyov'} />} title="Сегодня день рождения Михаила Лихачёва" subtitle={"Подарите подарок"} extraSubtitle={"Дополнительный текст"} - asideMode="dismiss" + after="dismiss" />Улучшения
after(в бывшемasideMode) теперь можно прокинуть любое значение;Tappableпараметры.