Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SubnavigationBar): replace prop mode to fixed flag #7792

Merged

Conversation

EldarMuhamethanov
Copy link
Contributor

@EldarMuhamethanov EldarMuhamethanov commented Oct 18, 2024


  • Unit-тесты
  • e2e-тесты
  • Release notes
  • Codemod

Описание

В компоненте SubnavigationBar заменил свойство mode на флаг fixed

Release notes

BREAKING CHANGE

  • SubnavigationBar: свойство mode заменено на флаг fixed
    <SubnavigationBar
    - mode={"fixed"}
    + fixed
    />
    
    <SubnavigationBar
    - mode={"overflow"}
    />

@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner October 18, 2024 10:18
Copy link
Contributor

size-limit report 📦

Path Size
JS 386.56 KB (-0.01% 🔽)
JS (gzip) 116.92 KB (-0.01% 🔽)
JS (brotli) 96 KB (+0.01% 🔺)
JS import Div (tree shaking) 1.46 KB (0%)
CSS 333.55 KB (0%)
CSS (gzip) 41.81 KB (0%)
CSS (brotli) 33.13 KB (0%)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit 0196b35

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.14%. Comparing base (e5c337d) to head (0196b35).
Report is 19 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7792   +/-   ##
=======================================
  Coverage   95.14%   95.14%           
=======================================
  Files         384      384           
  Lines       11357    11357           
  Branches     3727     3727           
=======================================
  Hits        10806    10806           
  Misses        551      551           
Flag Coverage Δ
unittests 95.14% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@EldarMuhamethanov EldarMuhamethanov merged commit 9d6db11 into master Oct 21, 2024
28 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/7791/subnav-bar-mode-rename-to-fixed branch October 21, 2024 13:01
@BlackySoul BlackySoul mentioned this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BREAKING CHANGE] SubnavigationBar: переименовать mode -> fixed(boolean флаг)
3 participants