Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(UsersStack): replace direction prop to avatarsPosition #7666

Conversation

EldarMuhamethanov
Copy link
Contributor

@EldarMuhamethanov EldarMuhamethanov commented Sep 26, 2024


  • e2e-тесты
  • Документация фичи
  • Release notes

Описание

Необходимо у компонента UsersStack переименовать проп direction в avatarsPosition со значениями 'start' | 'end' | 'top'

Изменения

  • Заменил проп direction на avatarsPosition со значениями 'inline-start' | 'inline-end' | 'block-start'
  • Обновил скришотные тесты
  • Добавил кодмод для замены пропа на корректное значение

Release notes

BREAKING CHANGE

  • UsersStack: параметр direction заменен на avatarsPosition со значениями 'inline-start' | 'inline-end' | 'block-start'
    <UsersStack
      photos={['photo1', 'photo2', 'photo3']}
    - direction="row-reverse"
    + avatarsPosition="inline-end"
      size="s"
    >
      Иван и ещё 2 ваших друга подписаны
    </UsersStack>

@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner September 26, 2024 11:15
Copy link
Contributor

github-actions bot commented Sep 26, 2024

size-limit report 📦

Path Size
JS 385.39 KB (+0.02% 🔺)
JS (gzip) 116.62 KB (+0.01% 🔺)
JS (brotli) 95.75 KB (-0.03% 🔽)
JS import Div (tree shaking) 1.46 KB (0%)
CSS 331.19 KB (+0.02% 🔺)
CSS (gzip) 41.51 KB (+0.01% 🔺)
CSS (brotli) 32.93 KB (+0.09% 🔺)

Copy link

codesandbox-ci bot commented Sep 26, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Sep 26, 2024

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Sep 26, 2024

👀 Docs deployed

Commit 830bf51

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.16%. Comparing base (4b12821) to head (830bf51).
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7666   +/-   ##
=======================================
  Coverage   95.16%   95.16%           
=======================================
  Files         383      383           
  Lines       11333    11333           
  Branches     3714     3714           
=======================================
  Hits        10785    10785           
  Misses        548      548           
Flag Coverage Δ
unittests 95.16% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤝

Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅

@EldarMuhamethanov EldarMuhamethanov merged commit f0f463c into master Sep 26, 2024
28 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/7665/users-stack-direction-to-avatarsPosition branch September 26, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants