-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Cell): rework disabled prop #7405
Conversation
size-limit report 📦
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests
|
👀 Docs deployed
Commit 0e6a19a |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7405 +/- ##
=======================================
Coverage 92.74% 92.74%
=======================================
Files 374 374
Lines 11111 11100 -11
Branches 3646 3644 -2
=======================================
- Hits 10305 10295 -10
+ Misses 806 805 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌞🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💅
* fix(Cell): rework disabled prop * CHORE: Update screenshots --------- Co-authored-by: GitHub Action <[email protected]>
✅ v6.5.1 🎉 |
Описание
Добавляем полноценную поддержку
disabled
-свойства. Раньше оно использовалось для того, что сделать ячейки неинтерактивными - теперь это решается отсутствием пропаonClick
.disabled
- помечает ячейку как недоступную (она становится серой).Изменения
disabled
disabled
- теперь проп наSimpleCell
(а не толькоCell
)disabled
иdraggable
на более подходящий, потому чтоdraggable
-ячейки не могут бытьdisabled