Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Cell): rework disabled prop #7405

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Conversation

BlackySoul
Copy link
Contributor

@BlackySoul BlackySoul commented Aug 19, 2024

  • Unit-тесты
  • e2e-тесты
  • Дизайн-ревью
  • Документация фичи

Описание

Добавляем полноценную поддержку disabled-свойства. Раньше оно использовалось для того, что сделать ячейки неинтерактивными - теперь это решается отсутствием пропа onClick. disabled - помечает ячейку как недоступную (она становится серой).

Изменения

  • убрала ненужные условия для disabled
  • disabled - теперь проп на SimpleCell (а не только Cell)
  • заменила тест disabled и draggable на более подходящий, потому что draggable-ячейки не могут быть disabled

@BlackySoul BlackySoul requested a review from a team as a code owner August 19, 2024 14:54
@BlackySoul BlackySoul linked an issue Aug 19, 2024 that may be closed by this pull request
@github-actions github-actions bot added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Aug 19, 2024
@BlackySoul BlackySoul marked this pull request as draft August 19, 2024 14:54
Copy link
Contributor

github-actions bot commented Aug 19, 2024

size-limit report 📦

Path Size
JS 378.01 KB (+0.01% 🔺)
JS (gzip) 114.62 KB (-0.01% 🔽)
JS (brotli) 94.15 KB (+0.01% 🔺)
JS import Div (tree shaking) 1.39 KB (0%)
CSS 305.62 KB (+0.02% 🔺)
CSS (gzip) 39.2 KB (-0.01% 🔽)
CSS (brotli) 31.45 KB (+0.01% 🔺)

Copy link

codesandbox-ci bot commented Aug 19, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Aug 19, 2024

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

Copy link
Contributor

github-actions bot commented Aug 19, 2024

👀 Docs deployed

Commit 0e6a19a

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.74%. Comparing base (590f508) to head (0e6a19a).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7405   +/-   ##
=======================================
  Coverage   92.74%   92.74%           
=======================================
  Files         374      374           
  Lines       11111    11100   -11     
  Branches     3646     3644    -2     
=======================================
- Hits        10305    10295   -10     
+ Misses        806      805    -1     
Flag Coverage Δ
unittests 92.74% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BlackySoul BlackySoul marked this pull request as ready for review August 19, 2024 15:11
@BlackySoul BlackySoul added this to the v6.5.1 milestone Aug 20, 2024
Copy link
Contributor

@qurle qurle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌞🔥

@BlackySoul BlackySoul self-assigned this Aug 20, 2024
Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅

@BlackySoul BlackySoul merged commit cbbc82e into master Aug 20, 2024
1 check passed
@BlackySoul BlackySoul deleted the fix/7326/Cell_fix_disabled branch August 20, 2024 09:03
vkcom-publisher pushed a commit that referenced this pull request Aug 20, 2024
* fix(Cell): rework disabled prop

* CHORE: Update screenshots

---------

Co-authored-by: GitHub Action <[email protected]>
@vkcom-publisher
Copy link
Contributor

v6.5.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: Свойство disabled не работает в Cell
6 participants