doc(CustomScrollView): use iframe to show documentation #7346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👀 Docs deployed
Commit 74cc851 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7346 +/- ##
=======================================
Coverage 92.51% 92.51%
=======================================
Files 374 374
Lines 11109 11109
Branches 3640 3640
=======================================
Hits 10278 10278
Misses 831 831
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mendrew
approved these changes
Aug 9, 2024
vkcom-publisher
added
pr-needs-work
inomdzhon
added
type:bug
cmp:custom-scroll-view
patch
inomdzhon
approved these changes
Aug 20, 2024
vkcom-publisher
pushed a commit
that referenced
this pull request
Aug 20, 2024
h2. Описание В документации CustomScrollView не отображается заголовок в примерах использования, из-за того, что там используется FixedLayout, для отображения примера не использовался iframe. Поэтому заголовок улетал вверх h2. Изменения Поправил доку CustomScrollView, чтобы в примере использовался iframe
| ✅ v6.5.1 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
В документации CustomScrollView не отображается заголовок в примерах использования, из-за того, что там используется FixedLayout, для отображения примера не использовался iframe. Поэтому заголовок улетал вверх
Изменения
Поправил доку CustomScrollView, чтобы в примере использовался iframe