fix(Group): add missed CSS class for sizeX="regular"
#7345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
patch
inomdzhon
added
type:bug
cmp:group
and removed
patch
size-limit report 📦
|
inomdzhon
added
the
patch
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
👀 Docs deployed
Commit 7f0bcfd |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7345 +/- ##
==========================================
+ Coverage 92.49% 92.51% +0.02%
==========================================
Files 374 374
Lines 11110 11109 -1
Branches 3641 3640 -1
==========================================
+ Hits 10276 10278 +2
+ Misses 834 831 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mendrew
approved these changes
Aug 8, 2024
BlackySoul
approved these changes
Aug 8, 2024
❌ PatchНе удалось автоматически применить исправление на ветке 6.5-stable.
Чтобы изменение попало в ветку 6.5-stable, выполните следующие действия:
git stash # опционально
git fetch origin 6.5-stable
git checkout -b patch/pr7345 origin/6.5-stable
git cherry-pick --no-commit 58e02bfa93d58d418446a72947aea96bd8e17a92
git checkout HEAD **/__image_snapshots__/*.png
git diff --quiet HEAD || git commit --no-verify --no-edit
git push --set-upstream origin patch/pr7345
gh pr create --base 6.5-stable --title "patch: pr7345" --body "- patch #7345" |
inomdzhon
added a commit
that referenced
this pull request
Aug 9, 2024
Класс `Group--sizeX-regular` должен был быть ещё в PR #7284, но видимо случайно ревертнул когда пушил. Без него не будет автоопределения для `mode="card"`, когда `mode === "none"` и `sizeX === "regular"`. Также исправляем тест из под #7333 – падал из-за того, что в PR был старый мастер без #7284. --- - caused by #7284, #7333
Merged
inomdzhon
added a commit
that referenced
this pull request
Aug 9, 2024
Класс `Group--sizeX-regular` должен был быть ещё в PR #7284, но видимо случайно ревертнул когда пушил. Без него не будет автоопределения для `mode="card"`, когда `mode === "none"` и `sizeX === "regular"`. Также исправляем тест из под #7333 – падал из-за того, что в PR был старый мастер без #7284. --- - caused by #7284, #7333
inomdzhon
added a commit
that referenced
this pull request
Aug 9, 2024
Класс `Group--sizeX-regular` должен был быть ещё в PR #7284, но видимо случайно ревертнул когда пушил. Без него не будет автоопределения для `mode="card"`, когда `mode === "none"` и `sizeX === "regular"`. Также исправляем тест из под #7333 – падал из-за того, что в PR был старый мастер без #7284. --- - caused by #7284, #7333
| ✅ v6.5.1 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Класс
Group--sizeX-regularдолжен был быть ещё в PR #7284, но видимо случайно ревертнул когда пушил. Без него не будет автоопределения дляmode="card", когдаmode === "none"иsizeX === "regular".Также исправляем тест из под #7333 – падал из-за того, что в PR был старый мастер без #7284.