-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(PopoutWrapper): fix scroll blocked #6265
fix(PopoutWrapper): fix scroll blocked #6265
Conversation
Теперь, при использовании `PopoutWrapper` напрямую, необходимо самостоятельно импортировать и вызывать `useScrollLock()` (см. #4314).
size-limit report 📦
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8671d00:
|
e2e tests |
👀 Docs deployed
Commit 8671d00 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Класс!
А может быть добавим в доку самого PopoutWrapper
информацию о useScrollLock()?
Отличная мысль! Добавил ⚡ b6c112b |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6265 +/- ##
==========================================
- Coverage 81.14% 81.14% -0.01%
==========================================
Files 324 324
Lines 10090 10086 -4
Branches 3386 3386
==========================================
- Hits 8188 8184 -4
Misses 1902 1902
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Шикарно, спасибо! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Описание
Теперь, при использовании
PopoutWrapper
напрямую, необходимо самостоятельно импортировать и вызыватьuseScrollLock()
(см. #4314).