Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PopoutWrapper): fix scroll blocked #6265

Merged

Conversation

inomdzhon
Copy link
Contributor


  • Unit-тесты
  • Гайд миграции

Описание

Теперь, при использовании PopoutWrapper напрямую, необходимо самостоятельно импортировать и вызывать useScrollLock() (см. #4314).

Теперь, при использовании `PopoutWrapper` напрямую, необходимо самостоятельно импортировать и вызывать `useScrollLock()` (см. #4314).
@inomdzhon inomdzhon requested a review from a team as a code owner December 12, 2023 13:25
Copy link
Contributor

github-actions bot commented Dec 12, 2023

size-limit report 📦

Path Size
JS 348.06 KB (-0.03% 🔽)
JS (gzip) 106.32 KB (-0.03% 🔽)
JS (brotli) 87.79 KB (-0.03% 🔽)
JS import Div (tree shaking) 1.43 KB (0%)
CSS 258.79 KB (0%)
CSS (gzip) 33.79 KB (0%)
CSS (brotli) 27.43 KB (0%)

Copy link

codesandbox-ci bot commented Dec 12, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8671d00:

Sandbox Source
VKUI TypeScript Configuration
[issue4314][PopoutWrapper] no scroll Issue #4314

Copy link
Contributor

github-actions bot commented Dec 12, 2023

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Dec 12, 2023

👀 Docs deployed

Commit 8671d00

mendrew
mendrew previously approved these changes Dec 12, 2023
Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Класс!

А может быть добавим в доку самого PopoutWrapper информацию о useScrollLock()?

@inomdzhon
Copy link
Contributor Author

Класс!

А может быть добавим в доку самого PopoutWrapper информацию о useScrollLock()?

Отличная мысль! Добавил ⚡ b6c112b

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bf6169d) 81.14% compared to head (8671d00) 81.14%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6265      +/-   ##
==========================================
- Coverage   81.14%   81.14%   -0.01%     
==========================================
  Files         324      324              
  Lines       10090    10086       -4     
  Branches     3386     3386              
==========================================
- Hits         8188     8184       -4     
  Misses       1902     1902              
Flag Coverage Δ
unittests 81.14% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mendrew
Copy link
Contributor

mendrew commented Dec 12, 2023

Класс!
А может быть добавим в доку самого PopoutWrapper информацию о useScrollLock()?

Отличная мысль! Добавил ⚡ b6c112b

Шикарно, спасибо!

Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@inomdzhon inomdzhon merged commit adfb81c into master Dec 13, 2023
24 checks passed
@inomdzhon inomdzhon deleted the imirdzhamolov/issue4314/fix/PopoutWrapper-els-scroll branch December 13, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][PopoutWrapper]: не скролится контент
3 participants