Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING CHANGE] feat: rm polyfills #6117

Merged

Conversation

inomdzhon
Copy link
Contributor

@inomdzhon inomdzhon commented Nov 16, 2023


Описание

Наш browserlist покрывает API, который мы полифилили. На текущий момент, нет нужды в полифилах.

Изменения

  • Удалил packages/vkui/lib/polyfills.ts и все его упоминания.
  • Также удалил их исключение из eslint-plugin-compat.

Наш `browserlist` покрывает API, который мы полифилили.
@inomdzhon inomdzhon requested a review from a team as a code owner November 16, 2023 12:41
@github-actions github-actions bot added the v5 Автоматизация: PR продублируется в ветку v5 label Nov 16, 2023
Copy link
Contributor

size-limit report 📦

Path Size
JS 335.21 KB (-0.36% 🔽)
JS (gzip) 102.48 KB (-0.26% 🔽)
JS (brotli) 84.63 KB (-0.15% 🔽)
JS import Div (tree shaking) 1.43 KB (-47.18% 🔽)
CSS 255.23 KB (0%)
CSS (gzip) 33.57 KB (0%)
CSS (brotli) 27.25 KB (0%)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 294710b:

Sandbox Source
VKUI TypeScript Configuration

Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit 294710b

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (107c29d) 79.38% compared to head (294710b) 79.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6117      +/-   ##
==========================================
+ Coverage   79.38%   79.81%   +0.42%     
==========================================
  Files         306      305       -1     
  Lines        9631     9570      -61     
  Branches     3261     3237      -24     
==========================================
- Hits         7646     7638       -8     
+ Misses       1985     1932      -53     
Flag Coverage Δ
unittests 79.81% <ø> (+0.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@inomdzhon inomdzhon removed the v5 Автоматизация: PR продублируется в ветку v5 label Nov 16, 2023
Copy link
Contributor

@eugpoloz eugpoloz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ну это пушка-бомба вообще 🔥

@github-actions github-actions bot added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Nov 24, 2023
@inomdzhon inomdzhon removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Nov 24, 2023
@inomdzhon inomdzhon modified the milestone: v6 Nov 24, 2023
@inomdzhon inomdzhon merged commit 03b0d8f into master Nov 24, 2023
26 checks passed
@inomdzhon inomdzhon deleted the imirdahamolov/issue1724/tech/rm-unneeded-polyfills branch November 24, 2023 11:25
@inomdzhon inomdzhon changed the title feat: rm polyfills [BREAKING CHANGE] feat: rm polyfills Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Проверить полифиллы методов
3 participants