Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Placeholder): add subcomponents #5629

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

SevereCloud
Copy link
Contributor

@SevereCloud SevereCloud commented Aug 16, 2023

@SevereCloud SevereCloud requested a review from a team as a code owner August 16, 2023 09:45
@SevereCloud SevereCloud added this to the v5.8.0 milestone Aug 16, 2023
@SevereCloud SevereCloud self-assigned this Aug 16, 2023
@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 16, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a6cb74c:

Sandbox Source
VKUI TypeScript Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2023

👀 Docs deployed

Commit 20b3fc0

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch coverage: 85.18% and project coverage change: -0.12% ⚠️

Comparison is base (ff44398) 81.88% compared to head (20b3fc0) 81.77%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5629      +/-   ##
==========================================
- Coverage   81.88%   81.77%   -0.12%     
==========================================
  Files         289      290       +1     
  Lines        9667     9745      +78     
  Branches     3076     3107      +31     
==========================================
+ Hits         7916     7969      +53     
- Misses       1751     1776      +25     
Flag Coverage Δ
unittests 81.77% <85.18%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...es/vkui/src/components/Placeholder/Placeholder.tsx 88.88% <85.18%> (-2.03%) ⬇️

... and 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2023

size-limit report 📦

Path Size
JS 316.57 KB (+0.16% 🔺)
JS (gzip) 93.26 KB (+0.15% 🔺)
JS (brotli) 77.06 KB (+0.13% 🔺)
JS import Div (tree shaking) 3.04 KB (0%)
CSS 275.8 KB (0%)
CSS (gzip) 36.01 KB (0%)
CSS (brotli) 28.56 KB (0%)

@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2023

e2e tests

Playwright Report

Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Супер! 👍

@BlackySoul
Copy link
Contributor

Кажется, получается, что порядок подкомпонентов сейчас важен, не нужно это как-то в доке обозначить?

@SevereCloud SevereCloud requested a review from mendrew August 16, 2023 14:48
mendrew
mendrew previously approved these changes Aug 16, 2023
@SevereCloud
Copy link
Contributor Author

Кажется, получается, что порядок подкомпонентов сейчас важен, не нужно это как-то в доке обозначить?

По идеи это ограничивается на уровне дизайна. Не уверен что нужно прямо обозначать ограничение

@github-actions github-actions bot added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Aug 26, 2023
Добавляем подкомпоненты для Placeholder
@SevereCloud SevereCloud force-pushed the SevereCloud/feat/Placeholder/add-subcomponents branch from 20b3fc0 to a6cb74c Compare August 30, 2023 09:53
@SevereCloud SevereCloud removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Aug 30, 2023
@github-actions
Copy link
Contributor

👀 Docs deployed

Commit a6cb74c

@SevereCloud SevereCloud merged commit 894f035 into master Aug 31, 2023
@SevereCloud SevereCloud deleted the SevereCloud/feat/Placeholder/add-subcomponents branch August 31, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants