-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Placeholder): add subcomponents #5629
feat(Placeholder): add subcomponents #5629
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a6cb74c:
|
👀 Docs deployedCommit 20b3fc0 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5629 +/- ##
==========================================
- Coverage 81.88% 81.77% -0.12%
==========================================
Files 289 290 +1
Lines 9667 9745 +78
Branches 3076 3107 +31
==========================================
+ Hits 7916 7969 +53
- Misses 1751 1776 +25
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
size-limit report 📦
|
e2e tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Супер! 👍
Кажется, получается, что порядок подкомпонентов сейчас важен, не нужно это как-то в доке обозначить? |
По идеи это ограничивается на уровне дизайна. Не уверен что нужно прямо обозначать ограничение |
Добавляем подкомпоненты для Placeholder
20b3fc0
to
a6cb74c
Compare
👀 Docs deployed
Commit a6cb74c |
Добавляем подкомпоненты для Placeholder