Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(FormItem): Add noPaddings prop to allow to disable paddings #5600

Merged

Conversation

mendrew
Copy link
Contributor

@mendrew mendrew commented Aug 10, 2023

resolves: #5598

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 10, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2d0bd78:

Sandbox Source
VKUI TypeScript Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Aug 10, 2023

size-limit report 📦

Path Size
JS 313.5 KB (+0.02% 🔺)
JS (gzip) 91.72 KB (+0.01% 🔺)
JS (brotli) 76.08 KB (-0.02% 🔽)
JS import Div (tree shaking) 2.97 KB (0%)
CSS 273.83 KB (+0.01% 🔺)
CSS (gzip) 35.71 KB (+0.02% 🔺)
CSS (brotli) 28.31 KB (+0.02% 🔺)

@github-actions
Copy link
Contributor

github-actions bot commented Aug 10, 2023

👀 Docs deployed

Commit 2d0bd78

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.06% 🎉

Comparison is base (1fd8f9a) 81.75% compared to head (2d0bd78) 81.82%.
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5600      +/-   ##
==========================================
+ Coverage   81.75%   81.82%   +0.06%     
==========================================
  Files         289      289              
  Lines        9621     9652      +31     
  Branches     3061     3071      +10     
==========================================
+ Hits         7866     7898      +32     
+ Misses       1755     1754       -1     
Flag Coverage Δ
unittests 81.82% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/vkui/src/components/FormItem/FormItem.tsx 77.77% <100.00%> (+1.03%) ⬆️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 10, 2023

e2e tests

Playwright Report

@mendrew mendrew marked this pull request as ready for review August 10, 2023 11:11
@mendrew mendrew requested a review from a team as a code owner August 10, 2023 11:11
inomdzhon
inomdzhon previously approved these changes Aug 10, 2023
Copy link
Contributor

@BlackySoul BlackySoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@inomdzhon inomdzhon merged commit fdf9a83 into master Aug 11, 2023
@inomdzhon inomdzhon deleted the mendrew/feature/5598/FormItem/allow-to-turn-off-paddings branch August 11, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Добавить возможность отключать отступы у FormItem
3 participants