fix(Group): spacing adaptivity #5364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SevereCloud
commented
Jun 27, 2023
•
SevereCloud
commented
- исправил адаптивность(вынес определение mode на js)
- исправил разделители между группами
- related to fix(Group): adaptivity #5344
- исправил адаптивность(вынес определение mode на js) - исправил разделители между группами
SevereCloud
added
the
patch
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c229a99:
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5364 +/- ##
==========================================
- Coverage 81.63% 81.63% -0.01%
==========================================
Files 283 283
Lines 9502 9505 +3
Branches 3029 3032 +3
==========================================
+ Hits 7757 7759 +2
- Misses 1745 1746 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
size-limit report 📦
|
👀 Docs deployedCommit c229a99 |
e2e tests |
inomdzhon
approved these changes
Jun 27, 2023
BlackySoul
approved these changes
Jun 27, 2023
inomdzhon
added a commit
that referenced
this pull request
Aug 2, 2024
1 task
inomdzhon
added a commit
that referenced
this pull request
Aug 5, 2024
inomdzhon
added a commit
that referenced
this pull request
Aug 7, 2024
h2. Описание - реструктурировал CSS файл, чтобы было понятней что к чему; - размеры заменил на токены из [@vkonktate/vkui-tokens](https://github.com/VKCOM/vkui-tokens/blob/ecdad88decf36df7ad14f5df493ba5adbddae6a5/src/themeDescriptions/base/paradigm.ts#L749-L759); - отказался от использования `<Separator />` из-за того, что его задевает `vkuiInternalModalPage`, вместо этого объединил `Group__separator--spacing` и `Group__separator--separator` в один элемент `Group__separator`; - добавил модификатор `Group--sizeX--regular`, т.к. он определяет `mode` как `"card"` при `sizeX="regular"`, если `mode === "none"`; - вынес `<Separator />` из `<div />` в `ModalPageHeader.tsx`, чтобы боковые отступы не влияли на размеры сепаратора. h3. Дизайн Внутри `ModalPage` При `platform="android"`/`platform="ios"` и `sizeX="regular"` в `ModalPageHeader` удаляем отступы у `Separator`. <img width="320" alt="image" src="https://github.com/user-attachments/assets/104f9be1-d7b5-4d60-8618-1d4dbee904f0"> <img width="313" alt="image" src="https://github.com/user-attachments/assets/53149f5b-e662-4908-9ae1-774b8e475dd8"> _до и после_ --- - related to #5344, #5364, #5371, #5642
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.