Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ChipsSelect): fix focusedOptionIndex logic #5129

Merged
merged 1 commit into from
May 25, 2023

Conversation

SevereCloud
Copy link
Contributor

Исправляем логику фокуса в ChipsSelect

- fixes #5051
@SevereCloud SevereCloud requested a review from a team as a code owner May 24, 2023 15:13
@SevereCloud SevereCloud added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label May 24, 2023
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c223752:

Sandbox Source
VKUI TypeScript Configuration

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 ⚠️

Comparison is base (9e47e2d) 81.95% compared to head (c223752) 81.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5129      +/-   ##
==========================================
- Coverage   81.95%   81.94%   -0.02%     
==========================================
  Files         281      281              
  Lines        9584     9577       -7     
  Branches     2997     2993       -4     
==========================================
- Hits         7855     7848       -7     
  Misses       1729     1729              
Flag Coverage Δ
a11ytests 8.71% <0.00%> (+0.01%) ⬆️
unittests 81.88% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/vkui/src/components/ChipsSelect/ChipsSelect.tsx 84.10% <100.00%> (-0.71%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

👀 Docs deployed

Commit c223752

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
JS 302.84 KB (-0.05% 🔽)
JS (gzip) 88.91 KB (-0.07% 🔽)
JS (brotli) 73.82 KB (-0.08% 🔽)
JS import Div (tree shaking) 2.97 KB (0%)
CSS 271.37 KB (0%)
CSS (gzip) 35.4 KB (0%)
CSS (brotli) 28.02 KB (0%)

@github-actions
Copy link
Contributor

e2e tests

Playwright Report

@SevereCloud SevereCloud merged commit 2a24b0e into master May 25, 2023
@SevereCloud SevereCloud deleted the SevereCloud/issue5051 branch May 25, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча
Projects
None yet
3 participants