Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NativeSelect&ChipsSelect): fix placeholder length #4497

Merged

Conversation

akcent1132
Copy link
Contributor

@akcent1132 akcent1132 commented Mar 16, 2023

@akcent1132 akcent1132 requested a review from a team as a code owner March 16, 2023 01:40
@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 16, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 779613d:

Sandbox Source
VKUI TypeScript Configuration
Selects Issue #2950

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (6fd6a4f) 81.05% compared to head (d68aea2) 81.05%.

❗ Current head d68aea2 differs from pull request most recent head 779613d. Consider uploading reports for the commit 779613d to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4497   +/-   ##
=======================================
  Coverage   81.05%   81.05%           
=======================================
  Files         338      338           
  Lines        8887     8889    +2     
  Branches     2929     2931    +2     
=======================================
+ Hits         7203     7205    +2     
  Misses       1684     1684           
Flag Coverage Δ
a11ytests 5.14% <0.00%> (-0.01%) ⬇️
e2e-chromium-android-dark 52.08% <100.00%> (+0.01%) ⬆️
e2e-chromium-android-light 52.08% <100.00%> (+0.10%) ⬆️
e2e-chromium-vkcom-dark 50.86% <100.00%> (+0.01%) ⬆️
e2e-chromium-vkcom-light 50.77% <100.00%> (-0.08%) ⬇️
e2e-firefox-vkcom-dark 50.77% <100.00%> (+0.01%) ⬆️
e2e-firefox-vkcom-light 50.77% <100.00%> (+0.01%) ⬆️
e2e-webkit-ios-dark 52.22% <100.00%> (+0.01%) ⬆️
e2e-webkit-ios-light 52.22% <100.00%> (+0.01%) ⬆️
e2e-webkit-vkcom-dark 50.83% <100.00%> (+0.01%) ⬆️
e2e-webkit-vkcom-light 50.83% <100.00%> (-0.02%) ⬇️
unittests 77.04% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...i/src/components/ChipsInputBase/ChipsInputBase.tsx 98.33% <100.00%> (+0.02%) ⬆️
.../vkui/src/components/NativeSelect/NativeSelect.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

👀 Styleguide deployed

See the styleguide for this PR at https://vkcom.github.io/VKUI/pull/4497/

@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2023

Changed screenshots

chipsinput-android-chromium-dark-1
chipsinput-android-chromium-light-1
chipsinput-ios-webkit-dark-1
chipsinput-ios-webkit-light-1
chipsinput-vkcom-chromium-dark-1
chipsinput-vkcom-chromium-light-1
chipsinput-vkcom-firefox-dark-1
chipsinput-vkcom-firefox-light-1
chipsinput-vkcom-webkit-dark-1
chipsinput-vkcom-webkit-light-1
formlayoutgroup-android-chromium-dark-1
formlayoutgroup-android-chromium-light-1
formlayoutgroup-ios-webkit-dark-1
formlayoutgroup-ios-webkit-light-1
formlayoutgroup-vkcom-chromium-dark-1
formlayoutgroup-vkcom-chromium-light-1
formlayoutgroup-vkcom-firefox-dark-1
formlayoutgroup-vkcom-firefox-light-1
formlayoutgroup-vkcom-webkit-dark-1
formlayoutgroup-vkcom-webkit-light-1
nativeselect-android-chromium-dark-1
nativeselect-android-chromium-light-1
nativeselect-ios-webkit-dark-1
nativeselect-ios-webkit-light-1
nativeselect-vkcom-chromium-dark-1
nativeselect-vkcom-chromium-light-1
nativeselect-vkcom-firefox-dark-1
nativeselect-vkcom-firefox-light-1
nativeselect-vkcom-webkit-dark-1
nativeselect-vkcom-webkit-light-1

@akcent1132 akcent1132 force-pushed the fix/select-components/fix-placeholder-length branch from 1e3d57d to 2ba104a Compare March 16, 2023 02:16
@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2023

size-limit report 📦

Path Size
JS 295.6 KB (+0.04% 🔺)
JS (gzip) 86.26 KB (+0.03% 🔺)
JS (brotli) 71.45 KB (-0.1% 🔽)
JS import Div (tree shaking) 2.4 KB (0%)
CSS 271.25 KB (+0.09% 🔺)
CSS (gzip) 34.91 KB (+0.1% 🔺)
CSS (brotli) 27.73 KB (-0.03% 🔽)

@SevereCloud SevereCloud added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Mar 16, 2023
@akcent1132 akcent1132 force-pushed the fix/select-components/fix-placeholder-length branch 2 times, most recently from 2ef13db to f90422a Compare March 16, 2023 23:46
SevereCloud
SevereCloud previously approved these changes Mar 17, 2023
inomdzhon
inomdzhon previously approved these changes Mar 21, 2023
@inomdzhon
Copy link
Contributor

@akcent1132 привет! Запусти, пожалуйста, в своей форкнутоый репе скриншотные тесты для своей ветки 🙏

2023-03-21.12.44.05.mov

Это уже не первый issue, который участвует в программе Fix Bounty. Ты точно не хочешь баллы ВКонтакте за них получать? :)

@github-actions github-actions bot dismissed stale reviews from inomdzhon and SevereCloud via 7373cce March 23, 2023 11:19
@akcent1132
Copy link
Contributor Author

@akcent1132 привет! Запусти, пожалуйста, в своей форкнутоый репе скриншотные тесты для своей ветки pray

Это уже не первый issue, который участвует в программе Fix Bounty. Ты точно не хочешь баллы ВКонтакте за них получать? :)

Добрый день, е2е запустил. Мне формы заполнять для участия в конкурсах неохота...

@inomdzhon
Copy link
Contributor

@akcent1132 спасибо за обновление 🙏

Но вижу теперь конфликты в PR :( Надо ребейзнуть master и снова запустить скриншоты

@akcent1132 akcent1132 force-pushed the fix/select-components/fix-placeholder-length branch from b81a3a0 to d68aea2 Compare March 23, 2023 15:23
@inomdzhon inomdzhon removed the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Mar 24, 2023
@inomdzhon inomdzhon merged commit bfaf62a into VKCOM:master Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Разное поведение длинного текста у Select компонентов
4 participants