-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NativeSelect&ChipsSelect): fix placeholder length #4497
fix(NativeSelect&ChipsSelect): fix placeholder length #4497
Conversation
akcent1132
commented
Mar 16, 2023
•
edited by SevereCloud
Loading
edited by SevereCloud
- fix [Bug]: Разное поведение длинного текста у Select компонентов #2950
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 779613d:
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4497 +/- ##
=======================================
Coverage 81.05% 81.05%
=======================================
Files 338 338
Lines 8887 8889 +2
Branches 2929 2931 +2
=======================================
+ Hits 7203 7205 +2
Misses 1684 1684
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
👀 Styleguide deployedSee the styleguide for this PR at https://vkcom.github.io/VKUI/pull/4497/ |
Changed screenshots |
1e3d57d
to
2ba104a
Compare
size-limit report 📦
|
packages/vkui/src/components/ChipsInputBase/ChipsInputBase.module.css
Outdated
Show resolved
Hide resolved
2ef13db
to
f90422a
Compare
@akcent1132 привет! Запусти, пожалуйста, в своей форкнутоый репе скриншотные тесты для своей ветки 🙏 2023-03-21.12.44.05.movЭто уже не первый issue, который участвует в программе Fix Bounty. Ты точно не хочешь баллы ВКонтакте за них получать? :) |
7373cce
Добрый день, е2е запустил. Мне формы заполнять для участия в конкурсах неохота... |
@akcent1132 спасибо за обновление 🙏 Но вижу теперь конфликты в PR :( Надо ребейзнуть |
b81a3a0
to
d68aea2
Compare