Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(HorizontalScroll): add scrollOnAnyWheel #4390

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

@SevereCloud SevereCloud requested a review from a team as a code owner March 3, 2023 12:15
@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 3, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 76afb78:

Sandbox Source
VKUI TypeScript Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

size-limit report 📦

Path Size
JS 294.24 KB (+0.1% 🔺)
JS (gzip) 85.92 KB (+0.14% 🔺)
JS (brotli) 71.19 KB (+0.09% 🔺)
JS import Div (tree shaking) 2.4 KB (0%)
CSS 270.66 KB (0%)
CSS (gzip) 34.74 KB (0%)
CSS (brotli) 27.61 KB (0%)

@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (591e04a) 80.80% compared to head (76afb78) 80.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4390      +/-   ##
==========================================
+ Coverage   80.80%   80.82%   +0.02%     
==========================================
  Files         336      336              
  Lines        8944     8955      +11     
  Branches     2948     2950       +2     
==========================================
+ Hits         7227     7238      +11     
  Misses       1717     1717              
Flag Coverage Δ
a11ytests 4.17% <0.00%> (-0.01%) ⬇️
e2e-chromium-android-dark 52.29% <50.00%> (-0.10%) ⬇️
e2e-chromium-android-light 52.29% <50.00%> (-0.10%) ⬇️
e2e-chromium-vkcom-dark 51.11% <50.00%> (-0.01%) ⬇️
e2e-chromium-vkcom-light 51.01% <50.00%> (-0.10%) ⬇️
e2e-firefox-vkcom-dark 51.01% <50.00%> (-0.01%) ⬇️
e2e-firefox-vkcom-light 51.01% <50.00%> (-0.01%) ⬇️
e2e-webkit-ios-dark 52.52% <50.00%> (-0.01%) ⬇️
e2e-webkit-ios-light 52.52% <50.00%> (-0.01%) ⬇️
e2e-webkit-vkcom-dark 51.08% <50.00%> (-0.01%) ⬇️
e2e-webkit-vkcom-light 51.08% <50.00%> (-0.04%) ⬇️
unittests 76.87% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/components/HorizontalScroll/HorizontalScroll.tsx 51.61% <100.00%> (+6.49%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

👀 Styleguide deployed

See the styleguide for this PR at https://vkcom.github.io/VKUI/pull/4390/

@SevereCloud SevereCloud force-pushed the SevereCloud/issue4367 branch from aed6101 to 76afb78 Compare March 6, 2023 09:33
@SevereCloud SevereCloud merged commit a53d570 into master Mar 9, 2023
@SevereCloud SevereCloud deleted the SevereCloud/issue4367 branch March 9, 2023 10:54
@nmoiseev777
Copy link

ребята, так нельзя делать, тк это ломает тачпад

@nmoiseev777
Copy link

мы пока сделали потаскуху через "драг мышкой"

@SevereCloud
Copy link
Contributor Author

@nmoiseev777 можно больше подробностей. Проверял на маковском тачпаде, все прекрасно работает

@SevereCloud
Copy link
Contributor Author

Пример можно сделать вот здесь https://codesandbox.io/s/vkui-typescript-wiri09

@nmoiseev777
Copy link

в идеале, ты хочешь сделать так, чтобы скролл работал только по колесику мыши, тк в случае с тачпадом не нужен вертикальный скролл (тем более скачками), но нормально это реализовать (проверку устройства или имитацию "нативного" скролла) в js нельзя.

@SevereCloud
Copy link
Contributor Author

в идеале, ты хочешь сделать так, чтобы скролл работал только по колесику мыши, тк в случае с тачпадом не нужен вертикальный скролл

На vk.com/feed истории прокручивается через тачпад. В нативном телеграме тоже тачпадом в любые стороны скроллится

@nmoiseev777
Copy link

если это всех устраивает, кто я такой, чтобы стоять на пути прогресса

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants