adds a trace filter to gather ruby gems and apps #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @quoideneuf, just so you know, you can update a pull request simply by updating your branch ( I'll try to review ASAP. |
remram44
added
T-enhancement
|
Thanks @remram44 Didn't know I could force / rebase and keep the PR - that is much nicer! Sorry about all the noise. I think I am getting the hang of pythonic line breaking... |
quoideneuf
force-pushed
the
rails-heuristic
branch
2 times, most recently
from
cd24e95 to
1ddd357
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some logic for getting subdirectories in a rails app in addition to gem directories. There may be some fine tuning necessary as to which directories, but now as a long as the rails app is started, all views, controllers, helpers, and models should be traced even if the app never receives a request.