Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Saving section snapshot in cloud storage #64

Merged
merged 7 commits into from
Mar 13, 2024
Merged

feat: Saving section snapshot in cloud storage #64

merged 7 commits into from
Mar 13, 2024

Conversation

erickzanardo
Copy link
Contributor

Description

Screenshots/Video

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Monday.com Item IDs

B0berman
B0berman previously approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@B0berman B0berman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little suggestion otherwise LGTM

api/test/routes/board/sections/[sectionId]_test.dart Outdated Show resolved Hide resolved
@erickzanardo erickzanardo requested a review from B0berman March 13, 2024 12:56
B0berman
B0berman previously approved these changes Mar 13, 2024
View reviewed changes
jsgalarraga
jsgalarraga reviewed Mar 13, 2024
View reviewed changes
api/packages/firebase_cloud_storage/pubspec.yaml Outdated Show resolved Hide resolved
api/packages/firebase_cloud_storage/analysis_options.yaml Outdated Show resolved Hide resolved
api/pubspec.yaml Show resolved Hide resolved
@erickzanardo erickzanardo merged commit 585c4eb into main Mar 13, 2024
8 checks passed
@erickzanardo erickzanardo deleted the feat/saving-section-in-cloudstorage branch March 13, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsgalarraga jsgalarraga jsgalarraga approved these changes

@AyadLaouissi AyadLaouissi Awaiting requested review from AyadLaouissi AyadLaouissi is a code owner

@B0berman B0berman Awaiting requested review from B0berman B0berman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erickzanardo @B0berman @jsgalarraga