Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beschreibung des Wertes "presentPower" stimmt nicht mit Feldname überein (Prio: Medium) #3

Open
meppingvector opened this issue Sep 30, 2021 · 6 comments · Fixed by #4 or #28
Open

Beschreibung des Wertes "presentPower" stimmt nicht mit Feldname überein (Prio: Medium) #3

meppingvector opened this issue Sep 30, 2021 · 6 comments · Fixed by #4 or #28
Assignees
@maikwoehl-psi
Labels
breaking change inkompatible Schemaänderung discussion required to be discussed in VDV463 WG specification Improvements or additions to specification
Milestone
Version 2.0.0

Comments

@meppingvector
Copy link

ChargingPointInfo: Beschreibung des Wertes "presentPower" stimmt nicht mit Feldname überein.
Beschreibung Feldname: Optional, aktuell verfügbare Leistung in [kW]
Unklar, ob verfügbare Leistung (availablePower) oder actual/presentPower, also die aktuelle Ladeleistung, gemeint ist.

Änderungsvorschlag:
"presentPower" gibt die vom LMS vorgegebene max. Ladeleistung an.
@maikwoehl-psi maikwoehl-psi added bug Issue in interface or specification specification Improvements or additions to specification and removed bug Issue in interface or specification labels Feb 21, 2022
@maikwoehl-psi
Copy link
Collaborator

Diese Zuordnung hätten wir uns auch gewünscht. Aktuell fehlt ja eine solche Angabe, bezogen auf den Ladepunkt. Das würde auch den Simulationen weiterhelfen.

@maikwoehl-psi
Copy link
Collaborator

Das Attribut wird in presentPowerLimit umbenannt und mit folgender Beschreibung versehen: Optional, vom LMS aktuell vorgegebene maximale Ladeleistung in [kW].

@maikwoehl-psi maikwoehl-psi self-assigned this Mar 22, 2022
@maikwoehl-psi
Copy link
Collaborator

Erwarte Pull Request

BenjaminKowatschVector added a commit to BenjaminKowatschVector/VDV463 that referenced this issue Mar 23, 2022
@BenjaminKowatschVector
Add v1.1 JSON schemas fixing issues VDVde#2 and VDVde#3
4157033
@maikwoehl-psi maikwoehl-psi linked a pull request Oct 27, 2022 that will close this issue
Add v1.1 JSON schemas fixing issues #2 and #3 #4
Merged
maikwoehl-psi added a commit to maikwoehl-psi/VDV463 that referenced this issue Jan 30, 2023
@maikwoehl-psi
Merge remote-tracking branch 'remotes/upstream/v1.1-dev' into Fix-iss…
4e663db 
…ues-VDVde#2-VDVde#3
@maikwoehl-psi maikwoehl-psi added this to the Version 1.1 milestone Jul 4, 2023
@amotech-mdo amotech-mdo linked a pull request Jul 4, 2023 that will close this issue
removing "uri" format constraint from all string identifiers #15
Closed
BenjaminKowatschVector added a commit to BenjaminKowatschVector/VDV463 that referenced this issue Oct 24, 2023
@BenjaminKowatschVector
Merge branch 'v1.1-dev' into Fix-issues-VDVde#2-VDVde#3
6d15dbe
@maikwoehl-psi
Copy link
Collaborator

maikwoehl-psi commented Oct 25, 2023 •
edited
Loading

  • Schemaänderung
  • Spezifikationsdokument ändern

@maikwoehl-psi maikwoehl-psi added ready Ready to Merge and removed ready Ready to Merge labels Oct 25, 2023
@maikwoehl-psi
Copy link
Collaborator

maikwoehl-psi commented Jan 17, 2024 •
edited
Loading

Grafiken: #4 (comment)

maikwoehl-psi added a commit that referenced this issue Jan 17, 2024
@maikwoehl-psi
Merge pull request #4 from BenjaminKowatschVector/Fix-issues-#2-#3
bb9272b 
Add v1.1 JSON schemas fixing issues #2 and #3
@maikwoehl-psi
Copy link
Collaborator

grafik

@maikwoehl-psi maikwoehl-psi added the ready Ready to Merge label Jan 18, 2024
@DohmenClaus DohmenClaus added the breaking change inkompatible Schemaänderung label Feb 26, 2024
@DohmenClaus DohmenClaus modified the milestones: Version 1.1, Version 2.0 Feb 26, 2024
@DohmenClaus DohmenClaus added discussion required to be discussed in VDV463 WG and removed ready Ready to Merge accepted labels Feb 26, 2024
DohmenClaus added a commit that referenced this issue Feb 26, 2024
@DohmenClaus
Revert "Add v1.1 JSON schemas fixing issues #2 and #3"
3f9b706
DohmenClaus added a commit that referenced this issue Jul 8, 2024
@DohmenClaus
Merge pull request #28 from VDVde/revert-4-Fix-issues-#2-#3
dec81bb 
Revert "Add v1.1 JSON schemas fixing issues #2 and #3"
@maikwoehl-psi maikwoehl-psi linked a pull request Jul 8, 2024 that will close this issue
Revert "Add v1.1 JSON schemas fixing issues #2 and #3" #28
Merged
maikwoehl-psi added a commit that referenced this issue Dec 2, 2024
@maikwoehl-psi @BenjaminKowatschVector
@amotech-mdo @DohmenClaus @Basler182
Merge v1.1.0 to main (#38)
4cdb5df 
* Add v1.1 JSON schemas fixing issues #2 and #3

* Fixes #5

* removing "uri" format constraint from all string identifiers

as agreed in the VDV 463 meeting

* removing "uri" format constraint from all string identifiers

* removing "uri" format constraint from all string identifiers

* Remove obsolete whitespace changes

* #20: Allow empty arrays

* #22: Allow empty ChargingPredictionData

* #22: Add structure ChargingPredictionDataDepartureTime to ChargingPredictionData

* #22: Fix descriptions

* Update v1.1/ProvideChargingInformationRequest.json

Co-authored-by: Maik Wöhl <[email protected]>

* Update v1.1/ProvideChargingInformationRequest.json

Co-authored-by: Maik Wöhl <[email protected]>

* Add critical condition for tractionBattery, add hydrogentankinfo (#16)

* Add critical condition for tractionBattery, add hydrogentankinfo

* Move vehicleInfo into it's own list

* Add VehicleId to ChargingPointInfo to reference it

* Switch criticalCondition to integer to reflect SNA values

* Revert "Add VehicleId to ChargingPointInfo to reference it"

This reverts commit d14814e.

Revert "Move vehicleInfo into it's own list"

This reverts commit 0aa89ce.

* Rename criticalCondition to status

* Revert "Add v1.1 JSON schemas fixing issues #2 and #3"

* Add evccId to VehicleInfo structure

Closes #30

* Revert "Add critical condition for tractionBattery, add hydrogentankinfo (#16)"

This reverts commit c82bf61.

* Add Validations to JSON Schema Properties (#36)

* Move changes of v1.1 to v1.0

Signed-off-by: Maik Wöhl <[email protected]>

* Rename v1.0 to schema

Signed-off-by: Maik Wöhl <[email protected]>

---------

Signed-off-by: Maik Wöhl <[email protected]>
Co-authored-by: Kowatsch, Benjamin <[email protected]>
Co-authored-by: Dominique Müller <[email protected]>
Co-authored-by: Benjamin Kowatsch <[email protected]>
Co-authored-by: DohmenClaus <[email protected]>
Co-authored-by: Kilian Schneider <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maikwoehl-psi maikwoehl-psi

Labels
breaking change inkompatible Schemaänderung discussion required to be discussed in VDV463 WG specification Improvements or additions to specification
Projects
None yet
Milestone
Version 2.0.0
3 participants
@maikwoehl-psi @meppingvector @DohmenClaus