Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #5132 - Align aerodrome naming with AIP #5133

Merged
merged 3 commits into from
Dec 27, 2023

Conversation

AliceFord
Copy link
Collaborator

Fixes #5132

Summary of changes

Aligned naming with AIP

Screenshots (if necessary)

n/a

I do love some standards :p

@AliceFord AliceFord self-assigned this Dec 10, 2023
@AliceFord AliceFord added the bug Bugs or errors label Dec 10, 2023
@PLM1995
Copy link
Collaborator

PLM1995 commented Dec 11, 2023

I do love some standards :p

I agree...

I just wonder about other things which contain reference to the airport's name, e.g. airspace. Kind of opens a can of worms, but you could take the line of "will update everything" - which would change the names of things needing to be displayed in the controller pack so require a controller pack change, etc. All becomes a lot of work to add "London" to Gatwick for example ;)

Maybe I'm overthinking it and having just the Basic.txt files the 'correct'/full names is enough, just feels a bit like we're then creating inconsistency in some instances.

Interested in others' thoughts as ever.

@AliceFord
Copy link
Collaborator Author

AliceFord commented Dec 11, 2023

I do love some standards :p

I agree...

I just wonder about other things which contain reference to the airport's name, e.g. airspace. Kind of opens a can of worms, but you could take the line of "will update everything" - which would change the names of things needing to be displayed in the controller pack so require a controller pack change, etc. All becomes a lot of work to add "London" to Gatwick for example ;)

Maybe I'm overthinking it and having just the Basic.txt files the 'correct'/full names is enough, just feels a bit like we're then creating inconsistency in some instances.

Interested in others' thoughts as ever.

Yeah I'd prefer not doing everything (although we could if we think that's necessary) - mainly I wanted to make the wording displayed to the controllers (i.e. in the Runway Selection dialog) agree with the AIP, as in some cases (e.g. Wolverhampton/Halfpenny Green), what we currently have doesn't reflect the full name of the airport, and in others just helps to standardise. In many more cases than I have here the airspace / other text is different from the exact name of the airport, but that doesn't really matter for the controllers as they never see that.

@luke11brown luke11brown merged commit 889ce20 into VATSIM-UK:main Dec 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs or errors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align aerodrome naming with AIP
3 participants