-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pagy 8 support #65
Pagy 8 support #65
Conversation
@@ -1,3 +0,0 @@ | |||
module PagyCursor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we removing this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Migrate this constant to pagy_cursor.rb
for simplicity.
I can revert the change.
The PR was my personal hack originally, so combine a few of off-topic changes
BTW, this branch works for my projects, but I don't know why
|
The error is here. |
I added back |
interesting... only Ruby 3.3 with Rails 7.1 failed |
This PR mixed a few of things: