Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Dependencies #218

Merged
merged 12 commits into from
Feb 17, 2020
Merged

Upgrade Dependencies #218

merged 12 commits into from
Feb 17, 2020

Conversation

leonardoventurini
Copy link
Collaborator

@leonardoventurini leonardoventurini commented Feb 16, 2020

  • Upgrade all dependencies.
  • Remove sub-steps from the table of contents.
  • Make sure all tests pass.

Note: I started using Jest's snapshot system for the deterministic tests (which everything should be?) please review the snapshots, as I could not find anything wrong with them by comparing with the original dump files. It seems like the "Begin tutorial" navigation bar at the bottom was added later nd it broke some of the tests...

image

@DAB0mB
Copy link
Collaborator

DAB0mB commented Feb 17, 2020

Why did you decide to remove sub-steps from TOC?

@leonardoventurini
Copy link
Collaborator Author

Why did you decide to remove sub-steps from TOC?

I talked with the other guys working on the tutorials, and we decided it would not be necessary @DAB0mB and it would eliminate the complexity entailing it.

@DAB0mB
Copy link
Collaborator

DAB0mB commented Feb 17, 2020

@leonardoventurini sounds good. Also snapshots look alright, there are 15 skipped tests, why is that? its been a while since I ran the project, just wanna make sure

@leonardoventurini
Copy link
Collaborator Author

@leonardoventurini sounds good. Also snapshots look alright, there are 15 skipped tests, why is that? its been a while since I ran the project, just wanna make sure

I don't know, honestly, they were already skipped... so I avoided messing with them for the time being as my schedule is already tight. I can take a look in the future, but I can't guarantee when, since I have some stuff come up for the following weeks. 🤔

@DAB0mB DAB0mB merged commit a996c95 into master Feb 17, 2020
@DAB0mB
Copy link
Collaborator

DAB0mB commented Feb 17, 2020

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants