-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Time scalar validation is too strict #469
Comments
I think RFC 3339 doesn't allow lowercase, does it? |
https://tools.ietf.org/html/rfc3339#page-10
But 5.6 of the spec is essentially a much more restricted version of RFC 3339. I at first didn't notice you're specifically implementing only section 5.6 of the larger RFC 3339 specification. In my opinion, this specification waffles back and forth between "may" and "should" without ever being clear about what to expect. It is all over the place in terms of whether it wants to be strict or not. |
Fixed in the latest version! |
The regex used to validate ISO8601 times is more strict than the general standard. For example, the timezone offset is supposed to be optional. You also do not allow specification of hours without minutes or minutes without seconds. It also does not allow lower case "z" or "t" as per the RFC 3339 spec..
The text was updated successfully, but these errors were encountered: