Allow empty typeDefs

Urigo · Feb 28, 2019 · 4d2679c · 4d2679c
1 parent 4818184
commit 4d2679c
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 3 deletions.
diff --git a/packages/core/src/graphql-module.ts b/packages/core/src/graphql-module.ts
@@ -552,9 +552,11 @@ export class GraphQLModule<Config = any, Session = any, Context = any> {
       if (typeof typeDefsDefinitions === 'string') {
         typeDefs = parse(typeDefsDefinitions);
       } else if (Array.isArray(typeDefsDefinitions)) {
-        typeDefs = mergeTypeDefs(typeDefsDefinitions, {
-          useSchemaDefinition: false,
-        });
+        if (typeDefsDefinitions.length) {
+          typeDefs = mergeTypeDefs(typeDefsDefinitions, {
+            useSchemaDefinition: false,
+          });
+        }
       } else if (typeDefsDefinitions) {
         typeDefs = typeDefsDefinitions;
       }

diff --git a/packages/core/tests/graphql-module.spec.ts b/packages/core/tests/graphql-module.spec.ts
@@ -1282,4 +1282,21 @@ describe('GraphQLModule', () => {
     });
     expect(data.foo).toBe('FOO');
   });
+  it('should generate schemaless module if empty typeDefs and resolvers specified', async () => {
+    const { schema: schemaA } = new GraphQLModule({
+      typeDefs: [],
+      resolvers: {},
+    });
+    expect(schemaA).toBeNull();
+    const { schema: schemaB } = new GraphQLModule({
+      typeDefs: '',
+      resolvers: {},
+    });
+    expect(schemaB).toBeNull();
+    const { schema: schemaC } = new GraphQLModule({
+      typeDefs: [''],
+      resolvers: {},
+    });
+    expect(schemaC).toBeNull();
+  });
 });