Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace winston with custom logger #534

Merged
merged 2 commits into from
Aug 27, 2020
Merged

Replace winston with custom logger #534

merged 2 commits into from
Aug 27, 2020

Conversation

TrySound
Copy link
Collaborator

@TrySound TrySound commented Aug 26, 2020

Ref https://packagephobia.com/result?p=winston

I just found winston package is quote big for such simple task as
colorized logging. At least in this project all winston power was not used.

In this diff I added very basic loggin solution with for levels "error",
"warn", "info" and "debug".

Ref https://packagephobia.com/result?p=winston

I just found winston package is quote big for such simple task as
colorized loggin. At least in this project all winston power was not used.

In this diff I added very basic loggin solution with for levels "error",
"warn", "info" and "debug".
@TrySound
Copy link
Collaborator Author

cc @ardatan

@ardatan ardatan requested a review from kamilkisiela August 26, 2020 15:17
@ardatan ardatan added the enhancement New feature or request label Aug 27, 2020
@ardatan
Copy link
Collaborator

ardatan commented Aug 27, 2020

Thanks @TrySound ! How about having an environmental variable (e.g. SOFA_DEBUG) that exposes debug logs and/or another variable that changes the logger level (e.g. SOFA_LOGGER_LEVEL=debug)?

@TrySound
Copy link
Collaborator Author

@ardatan Added both

@ardatan
Copy link
Collaborator

ardatan commented Aug 27, 2020

Awesome! Thanks!

@ardatan ardatan merged commit 8211b4b into Urigo:master Aug 27, 2020
@TrySound TrySound deleted the drop-winston branch August 27, 2020 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants