Fix payload parsing for subscriptions #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @csuriano23 ! |
ardatan
requested changes
Aug 22, 2022
|
Sure, I have to give a look on how the tests are structured and I am adding a case |
|
@ardatan Done. Take a look |
ardatan
force-pushed
the
fix/subscriptions-payload
branch
from
4abfe5a to
1952913
Compare
|
🎉 |
|
Thank you @csuriano23 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the subscription manager do not parse in a proper way the JSON payload for parametrical subscriptions.
The PR fixes this behaviour, applying in the existing reduction the event variables to the subscription schema and using for each variable the designated name from the schema